Skip to content

Commit 3c58c89

Browse files
feature #50391 [FrameworkBundle][HttpKernel] Introduce $buildDir argument to WarmableInterface::warmup to warm read-only artefacts in build_dir (Okhoshi)
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [FrameworkBundle][HttpKernel] Introduce `$buildDir` argument to `WarmableInterface::warmup` to warm read-only artefacts in `build_dir` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #50357 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> See #50357 for the details and the reproduction steps. In this PR, I also moved `ConfigBuilderCacheWarmer` to use the `buildDir` argument. Commits ------- 8b604ff3ae [FrameworkBundle][HttpKernel] Introduce `$buildDir` argument to `WarmableInterface::warmup` to warm read-only artefacts in `build_dir`
2 parents 6d60b9d + eb1edcf commit 3c58c89

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

CacheWarmer/ProxyCacheWarmer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ public function isOptional(): bool
3838
}
3939

4040
/**
41-
* @return string[] A list of files to preload on PHP 7.4+
41+
* @param string|null $buildDir
4242
*/
43-
public function warmUp(string $cacheDir): array
43+
public function warmUp(string $cacheDir /* , string $buildDir = null */): array
4444
{
4545
$files = [];
4646
foreach ($this->registry->getManagers() as $em) {

0 commit comments

Comments
 (0)