Skip to content

Commit 9f47c56

Browse files
Merge branch '4.4' into 5.2
* 4.4: Allow psr/cache v3 but on symfony/cache [DI] fix tracking of changes to vendor/ dirs Remove EOLed 5.1 branch from PR template [HttpKernel] [Kernel] Silence deprecations logs writes Update PULL_REQUEST_TEMPLATE.md [Mailer][Mime] Update inline part names with newly generated ContentId Fixed updating catalogue metadata from intl domain [HttpFoundation] Setting `REQUEST_TIME_FLOAT` when constructing a Request object
2 parents 62f7218 + 3d82e9c commit 9f47c56

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

ContainerBuilder.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1599,14 +1599,14 @@ private function getExpressionLanguage(): ExpressionLanguage
15991599
private function inVendors(string $path): bool
16001600
{
16011601
if (null === $this->vendors) {
1602-
$resource = new ComposerResource();
1603-
$this->vendors = $resource->getVendors();
1604-
$this->addResource($resource);
1602+
$this->vendors = (new ComposerResource())->getVendors();
16051603
}
16061604
$path = realpath($path) ?: $path;
16071605

16081606
foreach ($this->vendors as $vendor) {
16091607
if (0 === strpos($path, $vendor) && false !== strpbrk(substr($path, \strlen($vendor), 1), '/'.\DIRECTORY_SEPARATOR)) {
1608+
$this->addResource(new FileResource($vendor.'/composer/installed.json'));
1609+
16101610
return true;
16111611
}
16121612
}

Tests/ContainerBuilderTest.php

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
use PHPUnit\Framework\TestCase;
1919
use Psr\Container\ContainerInterface as PsrContainerInterface;
2020
use Symfony\Bridge\PhpUnit\ExpectDeprecationTrait;
21-
use Symfony\Component\Config\Resource\ComposerResource;
2221
use Symfony\Component\Config\Resource\DirectoryResource;
2322
use Symfony\Component\Config\Resource\FileResource;
2423
use Symfony\Component\Config\Resource\ResourceInterface;
@@ -952,7 +951,7 @@ public function testAddObjectResource()
952951

953952
$resources = $container->getResources();
954953

955-
$this->assertCount(2, $resources, '2 resources were registered');
954+
$this->assertCount(1, $resources);
956955

957956
/* @var $resource \Symfony\Component\Config\Resource\FileResource */
958957
$resource = end($resources);
@@ -981,9 +980,9 @@ public function testGetReflectionClass()
981980

982981
$resources = $container->getResources();
983982

984-
$this->assertCount(3, $resources, '3 resources were registered');
983+
$this->assertCount(2, $resources);
985984

986-
$this->assertSame('reflection.BarClass', (string) $resources[1]);
985+
$this->assertSame('reflection.BarClass', (string) $resources[0]);
987986
$this->assertSame('BarMissingClass', (string) end($resources));
988987
}
989988

@@ -1044,7 +1043,6 @@ public function testResources()
10441043
public function testFileExists()
10451044
{
10461045
$container = new ContainerBuilder();
1047-
$A = new ComposerResource();
10481046
$a = new FileResource(__DIR__.'/Fixtures/xml/services1.xml');
10491047
$b = new FileResource(__DIR__.'/Fixtures/xml/services2.xml');
10501048
$c = new DirectoryResource($dir = \dirname($b));
@@ -1058,7 +1056,7 @@ public function testFileExists()
10581056
}
10591057
}
10601058

1061-
$this->assertEquals([$A, $a, $b, $c], $resources, '->getResources() returns an array of resources read for the current configuration');
1059+
$this->assertEquals([$a, $b, $c], $resources, '->getResources() returns an array of resources read for the current configuration');
10621060
}
10631061

10641062
public function testExtension()

Tests/Loader/GlobFileLoaderTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function testLoadAddsTheGlobResourceToTheContainer()
3232
$loader = new GlobFileLoaderWithoutImport($container = new ContainerBuilder(), new FileLocator());
3333
$loader->load(__DIR__.'/../Fixtures/config/*');
3434

35-
$this->assertEquals(new GlobResource(__DIR__.'/../Fixtures/config', '/*', false), $container->getResources()[1]);
35+
$this->assertEquals(new GlobResource(__DIR__.'/../Fixtures/config', '/*', false), $container->getResources()[0]);
3636
}
3737
}
3838

0 commit comments

Comments
 (0)