Skip to content

Commit 81b7b37

Browse files
committed
Merge branch '2.3' into 2.6
* 2.3: replaced the last remaining is_integer() call [2.3] [Config] [Console] [DependencyInjection] [DomCrawler] [Form] [HttpKernel] [PropertyAccess] [Security] [Translation] [Yaml] static code analysis, code cleanup [Validator] Added missing galician (gl) translations [travis] Tests Security sub-components [travis] Tests Security sub-components CS fixes [travis] test with php nightly Conflicts: src/Symfony/Component/Security/Http/Tests/Firewall/RememberMeListenerTest.php
2 parents 7efe03e + 34439fb commit 81b7b37

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

Dumper/PhpDumper.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1169,7 +1169,7 @@ private function getServiceCallsFromArguments(array $arguments, array &$calls, a
11691169
$behavior[$id] = $argument->getInvalidBehavior();
11701170
}
11711171

1172-
$calls[$id] += 1;
1172+
++$calls[$id];
11731173
}
11741174
}
11751175
}
@@ -1478,12 +1478,12 @@ private function getNextVariableName()
14781478
}
14791479

14801480
while ($i > 0) {
1481-
$i -= 1;
1481+
--$i;
14821482
$name .= $nonFirstChars[$i%$nonFirstCharsLength];
14831483
$i = intval($i/$nonFirstCharsLength);
14841484
}
14851485

1486-
$this->variableCount += 1;
1486+
++$this->variableCount;
14871487

14881488
// check that the name is not reserved
14891489
if (in_array($name, $this->reservedVariables, true)) {

Tests/ContainerBuilderTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,8 @@ public function testAddGetCompilerPass()
260260
$builder->setResourceTracking(false);
261261
$builderCompilerPasses = $builder->getCompiler()->getPassConfig()->getPasses();
262262
$builder->addCompilerPass($this->getMock('Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface'));
263-
$this->assertEquals(sizeof($builderCompilerPasses) + 1, sizeof($builder->getCompiler()->getPassConfig()->getPasses()));
263+
264+
$this->assertCount(count($builder->getCompiler()->getPassConfig()->getPasses()) - 1, $builderCompilerPasses);
264265
}
265266

266267
/**

Tests/Dumper/PhpDumperTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@ public function testDumpRelativeDir()
7474

7575
$container = new ContainerBuilder();
7676
$container->setDefinition('test', $definition);
77-
$container->setParameter('foo', 'wiz'.dirname(dirname(__FILE__)));
78-
$container->setParameter('bar', dirname(__FILE__));
77+
$container->setParameter('foo', 'wiz'.dirname(__DIR__));
78+
$container->setParameter('bar', __DIR__);
7979
$container->setParameter('baz', '%bar%/PhpDumperTest.php');
8080
$container->setParameter('buz', dirname(dirname(__DIR__)));
8181
$container->compile();

0 commit comments

Comments
 (0)