bug #48449 [DependencyInjection] Fix bug when tag name is a text node (BrandonlinU)

This PR was squashed before being merged into the 6.2 branch.

Discussion
----------

[DependencyInjection] Fix bug when tag name is a text node

| Q             | A
| ------------- | ---
| Branch?       | 6.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #48445
| License       | MIT

Following the discussion in the ticket, I added a test for a tag without name attribute and content inside the tag for the name. I use `$tag->childElementCount !== 0` instead of `$tag->hasChildNode()` to detect if a `<attribute>` tag is present in the tag definition, or is only the name of the tag.

Commits
-------

b9337f1768 [DependencyInjection] Fix bug when tag name is a text node

Author: nicolas-grekas

Loader/XmlFileLoader.php

@@ -336,7 +336,7 @@ private function parseDefinition(\DOMElement $service, string $file, Definition
         $tags = $this->getChildren($service, 'tag');
 
         foreach ($tags as $tag) {
-            if ('' === $tagName = $tag->hasChildNodes() || '' === $tag->nodeValue ? $tag->getAttribute('name') : $tag->nodeValue) {
+            if ('' === $tagName = $tag->childElementCount || '' === $tag->nodeValue ? $tag->getAttribute('name') : $tag->nodeValue) {
                 throw new InvalidArgumentException(sprintf('The tag name for service "%s" in "%s" must be a non-empty string.', (string) $service->getAttribute('id'), $file));
             }
 

Tests/Fixtures/xml/services10.xml

@@ -11,6 +11,10 @@
             other-option="lorem"
             an_other-option="ipsum"
         />
+        <tag some-option="cat"
+            some_option="ciz"
+            other-option="lorem"
+            an_other-option="ipsum">bar_tag</tag>
     </service>
   </services>
 </container>

Tests/Loader/XmlFileLoaderTest.php

@@ -369,13 +369,17 @@ public function testParsesIteratorArgument()
         $this->assertEquals([new IteratorArgument(['k1' => new Reference('foo.baz'), 'k2' => new Reference('service_container')]), new IteratorArgument([])], $lazyDefinition->getArguments(), '->load() parses lazy arguments');
     }
 
-    public function testParsesTags()
+    /**
+     * @testWith ["foo_tag"]
+     *           ["bar_tag"]
+     */
+    public function testParsesTags(string $tag)
     {
         $container = new ContainerBuilder();
         $loader = new XmlFileLoader($container, new FileLocator(self::$fixturesPath.'/xml'));
         $loader->load('services10.xml');
 
-        $services = $container->findTaggedServiceIds('foo_tag');
+        $services = $container->findTaggedServiceIds($tag);
         $this->assertCount(1, $services);
 
         foreach ($services as $id => $tagAttributes) {