Use typed properties in tests as much as possible

Author: nicolas-grekas

Tests/Compiler/AbstractRecursivePassTest.php

@@ -36,7 +36,7 @@ public function testGetConstructorResolvesFactoryChildDefinitionsClass()
             ->setFactory([new Reference('child'), 'createFactory']);
 
         $pass = new class() extends AbstractRecursivePass {
-            public $actual;
+            public \ReflectionMethod $actual;
 
             protected function processValue($value, $isRoot = false): mixed
             {
@@ -62,7 +62,7 @@ public function testGetConstructorResolvesChildDefinitionsClass()
         $container->setDefinition('foo', new ChildDefinition('parent'));
 
         $pass = new class() extends AbstractRecursivePass {
-            public $actual;
+            public \ReflectionMethod $actual;
 
             protected function processValue($value, $isRoot = false): mixed
             {
@@ -88,7 +88,7 @@ public function testGetReflectionMethodResolvesChildDefinitionsClass()
         $container->setDefinition('foo', new ChildDefinition('parent'));
 
         $pass = new class() extends AbstractRecursivePass {
-            public $actual;
+            public \ReflectionMethod $actual;
 
             protected function processValue($value, $isRoot = false): mixed
             {

Tests/Compiler/ExtensionCompilerPassTest.php

@@ -22,8 +22,8 @@
  */
 class ExtensionCompilerPassTest extends TestCase
 {
-    private $container;
-    private $pass;
+    private ContainerBuilder $container;
+    private ExtensionCompilerPass $pass;
 
     protected function setUp(): void
     {

Tests/Compiler/IntegrationTest.php

@@ -1089,7 +1089,7 @@ public function testTaggedIteratorAndLocatorWithExclude()
 
 class ServiceSubscriberStub implements ServiceSubscriberInterface
 {
-    public $container;
+    public ContainerInterface $container;
 
     public function __construct(ContainerInterface $container)
     {
@@ -1109,10 +1109,7 @@ class DecoratedServiceSubscriber
 
 class DecoratedServiceLocator implements ServiceProviderInterface
 {
-    /**
-     * @var ServiceLocator
-     */
-    private $locator;
+    private ServiceLocator $locator;
 
     public function __construct(ServiceLocator $locator)
     {
@@ -1153,7 +1150,7 @@ public function setSunshine($type)
 
 final class TagCollector implements CompilerPassInterface
 {
-    public $collectedTags;
+    public array $collectedTags;
 
     public function process(ContainerBuilder $container): void
     {

Tests/Compiler/ResolveParameterPlaceHoldersPassTest.php

@@ -14,13 +14,14 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\Compiler\ResolveParameterPlaceHoldersPass;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException;
 
 class ResolveParameterPlaceHoldersPassTest extends TestCase
 {
-    private $compilerPass;
-    private $container;
-    private $fooDefinition;
+    private ResolveParameterPlaceHoldersPass $compilerPass;
+    private ContainerBuilder $container;
+    private Definition $fooDefinition;
 
     protected function setUp(): void
     {

Tests/Compiler/ServiceLocatorTagPassTest.php

@@ -230,10 +230,7 @@ public function testBindingsAreProcessed()
 
 class Locator
 {
-    /**
-     * @var ServiceLocator
-     */
-    public $locator;
+    public ServiceLocator $locator;
 
     public function __construct(ServiceLocator $locator)
     {

Tests/Compiler/ValidateEnvPlaceholdersPassTest.php

@@ -371,8 +371,8 @@ public function getConfigTreeBuilder(): TreeBuilder
 
 class EnvExtension extends Extension
 {
-    private $configuration;
-    private $config;
+    private ConfigurationInterface $configuration;
+    private array $config;
 
     public function __construct(ConfigurationInterface $configuration = null)
     {

Tests/Config/ContainerParametersResourceCheckerTest.php

@@ -13,21 +13,15 @@
 
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
-use Symfony\Component\Config\ResourceCheckerInterface;
 use Symfony\Component\DependencyInjection\Config\ContainerParametersResource;
 use Symfony\Component\DependencyInjection\Config\ContainerParametersResourceChecker;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
 class ContainerParametersResourceCheckerTest extends TestCase
 {
-    /** @var ContainerParametersResource */
-    private $resource;
-
-    /** @var ResourceCheckerInterface */
-    private $resourceChecker;
-
-    /** @var ContainerInterface */
-    private $container;
+    private ContainerParametersResource $resource;
+    private ContainerParametersResourceChecker $resourceChecker;
+    private MockObject&ContainerInterface $container;
 
     protected function setUp(): void
     {

Tests/Config/ContainerParametersResourceTest.php

@@ -16,8 +16,7 @@
 
 class ContainerParametersResourceTest extends TestCase
 {
-    /** @var ContainerParametersResource */
-    private $resource;
+    private ContainerParametersResource $resource;
 
     protected function setUp(): void
     {

Tests/ContainerTest.php

@@ -315,7 +315,7 @@ public function testReset()
     {
         $c = new Container();
         $c->set('bar', $bar = new class() implements ResetInterface {
-            public $resetCounter = 0;
+            public int $resetCounter = 0;
 
             public function reset(): void
             {

Tests/CrossCheckTest.php

@@ -17,7 +17,7 @@
 
 class CrossCheckTest extends TestCase
 {
-    protected static $fixturesPath;
+    protected static string $fixturesPath;
 
     public static function setUpBeforeClass(): void
     {