Merge branch '5.2' into 5.x

* 5.2:
  make fabbot happy
  use correct spelling when accessing the SMTP php.ini value
  Fix issue 40507: Tabs as separators between tokens
  [Cache] phpredis: Added full TLS support for RedisCluster
  [DependencyInjection][AliasDeprecatedPublicServicesPass] Noop when the service is private

Author: derrabus

Compiler/AliasDeprecatedPublicServicesPass.php

@@ -58,7 +58,7 @@ public function process(ContainerBuilder $container)
 
             $definition = $container->getDefinition($id);
             if (!$definition->isPublic() || $definition->isPrivate()) {
-                throw new InvalidArgumentException(sprintf('The "%s" service is private: it cannot have the "%s" tag.', $id, $this->tagName));
+                continue;
             }
 
             $container

Tests/Compiler/AliasDeprecatedPublicServicesPassTest.php

@@ -59,14 +59,13 @@ public function processWithMissingAttributeProvider()
 
     public function testProcessWithNonPublicService()
     {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('The "foo" service is private: it cannot have the "container.private" tag.');
-
         $container = new ContainerBuilder();
         $container
             ->register('foo')
             ->addTag('container.private', ['package' => 'foo/bar', 'version' => '1.2']);
 
         (new AliasDeprecatedPublicServicesPass())->process($container);
+
+        $this->assertTrue($container->hasDefinition('foo'));
     }
 }