[DI] dont inline when lazy edges are found

nicolas-grekas · nicolas-grekas · commit 5be2d762b510 · 2018-12-02T16:50:25.000+01:00
diff --git a/Compiler/InlineServiceDefinitionsPass.php b/Compiler/InlineServiceDefinitionsPass.php
@@ -130,7 +130,7 @@ private function isInlineableDefinition($id, Definition $definition, ServiceRefe
         $isReferencedByConstructor = false;
         foreach ($graph->getNode($id)->getInEdges() as $edge) {
             $isReferencedByConstructor = $isReferencedByConstructor || $edge->isReferencedByConstructor();
-            if ($edge->isWeak()) {
+            if ($edge->isWeak() || $edge->isLazy()) {
                 return false;
             }
             $ids[] = $edge->getSourceNode()->getId();

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ private function isInlineableDefinition($id, Definition $definition, ServiceRefe`
`130`	`130`	`$isReferencedByConstructor = false;`
`131`	`131`	`foreach ($graph->getNode($id)->getInEdges() as $edge) {`
`132`	`132`	`$isReferencedByConstructor = $isReferencedByConstructor \|\| $edge->isReferencedByConstructor();`
`133`		`- if ($edge->isWeak()) {`
	`133`	`+ if ($edge->isWeak() \|\| $edge->isLazy()) {`
`134`	`134`	`return false;`
`135`	`135`	`}`
`136`	`136`	`$ids[] = $edge->getSourceNode()->getId();`