Skip to content

Commit 353ad95

Browse files
Merge branch '3.4' into 4.3
* 3.4: bump phpunit-bridge cache-id Use assertStringContainsString when needed Use assert assertContainsEquals when needed Use assertEqualsWithDelta when required
2 parents 00d475b + a46a86d commit 353ad95

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Tests/Compiler/MergeExtensionConfigurationPassTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public function testExtensionConfigurationIsTrackedByDefault()
8585
$pass = new MergeExtensionConfigurationPass();
8686
$pass->process($container);
8787

88-
$this->assertContains(new FileResource(__FILE__), $container->getResources(), '', false, false);
88+
$this->assertContainsEquals(new FileResource(__FILE__), $container->getResources());
8989
}
9090

9191
public function testOverriddenEnvsAreMerged()

Tests/Loader/XmlFileLoaderTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ public function testExtensions()
462462

463463
$e = $e->getPrevious();
464464
$this->assertInstanceOf('InvalidArgumentException', $e, '->load() throws an InvalidArgumentException if the configuration does not validate the XSD');
465-
$this->assertContains('The attribute \'bar\' is not allowed', $e->getMessage(), '->load() throws an InvalidArgumentException if the configuration does not validate the XSD');
465+
$this->assertStringContainsString('The attribute \'bar\' is not allowed', $e->getMessage(), '->load() throws an InvalidArgumentException if the configuration does not validate the XSD');
466466
}
467467

468468
// non-registered extension
@@ -499,7 +499,7 @@ public function testExtensionInPhar()
499499

500500
$e = $e->getPrevious();
501501
$this->assertInstanceOf('InvalidArgumentException', $e, '->load() throws an InvalidArgumentException if the configuration does not validate the XSD');
502-
$this->assertContains('The attribute \'bar\' is not allowed', $e->getMessage(), '->load() throws an InvalidArgumentException if the configuration does not validate the XSD');
502+
$this->assertStringContainsString('The attribute \'bar\' is not allowed', $e->getMessage(), '->load() throws an InvalidArgumentException if the configuration does not validate the XSD');
503503
}
504504
}
505505

Tests/ParameterBag/EnvPlaceholderParameterBagTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public function testMergeWillNotDuplicateIdenticalParameters()
4141

4242
$this->assertCount(1, $placeholderForVariable);
4343
$this->assertIsString($placeholder);
44-
$this->assertContains($envVariableName, $placeholder);
44+
$this->assertStringContainsString($envVariableName, $placeholder);
4545
}
4646

4747
public function testMergeWhereFirstBagIsEmptyWillWork()
@@ -64,7 +64,7 @@ public function testMergeWhereFirstBagIsEmptyWillWork()
6464

6565
$this->assertCount(1, $placeholderForVariable);
6666
$this->assertIsString($placeholder);
67-
$this->assertContains($envVariableName, $placeholder);
67+
$this->assertStringContainsString($envVariableName, $placeholder);
6868
}
6969

7070
public function testMergeWherePlaceholderOnlyExistsInSecond()

0 commit comments

Comments
 (0)