Add missing return types

Author: wouterj

Argument/ReferenceSetArgumentTrait.php

@@ -44,6 +44,8 @@ public function getValues(): array
 
     /**
      * @param Reference[] $values The service references to put in the set
+     *
+     * @return void
      */
     public function setValues(array $values)
     {

Container.php

@@ -217,7 +217,7 @@ public function get(string $id, int $invalidBehavior = self::EXCEPTION_ON_INVALI
      *
      * As a separate method to allow "get()" to use the really fast `??` operator.
      */
-    private static function make(self $container, string $id, int $invalidBehavior)
+    private static function make(self $container, string $id, int $invalidBehavior): ?object
     {
         if (isset($container->loading[$id])) {
             throw new ServiceCircularReferenceException($id, array_merge(array_keys($container->loading), [$id]));
@@ -338,6 +338,8 @@ public static function underscore(string $id): string
 
     /**
      * Creates a service by requiring its factory file.
+     *
+     * @return mixed
      */
     protected function load(string $file)
     {

Dumper/PhpDumper.php

@@ -1325,7 +1325,7 @@ public function isCompiled(): bool
         if ($this->asFiles && !$this->inlineFactories) {
             $code .= <<<'EOF'
 
-    protected function load($file, $lazyLoad = true)
+    protected function load($file, $lazyLoad = true): mixed
     {
         if (class_exists($class = __NAMESPACE__.'\\'.$file, false)) {
             return $class::do($this, $lazyLoad);

Extension/Extension.php

@@ -28,11 +28,17 @@ abstract class Extension implements ExtensionInterface, ConfigurationExtensionIn
 {
     private array $processedConfigs = [];
 
+    /**
+     * @return string|false
+     */
     public function getXsdValidationBasePath()
     {
         return false;
     }
 
+    /**
+     * @return string
+     */
     public function getNamespace()
     {
         return 'http://example.org/schema/dic/'.$this->getAlias();
@@ -67,6 +73,9 @@ public function getAlias(): string
         return Container::underscore($classBaseName);
     }
 
+    /**
+     * @return ConfigurationInterface|null
+     */
     public function getConfiguration(array $config, ContainerBuilder $container)
     {
         $class = static::class;

Loader/YamlFileLoader.php

@@ -332,7 +332,7 @@ private function isUsingShortSyntax(array $service): bool
     /**
      * @throws InvalidArgumentException When tags are invalid
      */
-    private function parseDefinition(string $id, array|string|null $service, string $file, array $defaults, bool $return = false, bool $trackBindings = true)
+    private function parseDefinition(string $id, array|string|null $service, string $file, array $defaults, bool $return = false, bool $trackBindings = true): Definition|Alias|null
     {
         if (preg_match('/^_[a-zA-Z0-9_]*$/', $id)) {
             throw new InvalidArgumentException(sprintf('Service names that start with an underscore are reserved. Rename the "%s" service or define it in XML instead.', $id));
@@ -706,6 +706,8 @@ private function parseDefinition(string $id, array|string|null $service, string
         } else {
             $this->setDefinition($id, $definition);
         }
+
+        return null;
     }
 
     /**

ParameterBag/FrozenParameterBag.php

@@ -34,26 +34,41 @@ public function __construct(
         $this->resolved = true;
     }
 
+    /**
+     * @return never
+     */
     public function clear()
     {
         throw new LogicException('Impossible to call clear() on a frozen ParameterBag.');
     }
 
+    /**
+     * @return never
+     */
     public function add(array $parameters)
     {
         throw new LogicException('Impossible to call add() on a frozen ParameterBag.');
     }
 
+    /**
+     * @return never
+     */
     public function set(string $name, array|bool|string|int|float|\UnitEnum|null $value)
     {
         throw new LogicException('Impossible to call set() on a frozen ParameterBag.');
     }
 
+    /**
+     * @return never
+     */
     public function deprecate(string $name, string $package, string $version, string $message = 'The parameter "%s" is deprecated.')
     {
         throw new LogicException('Impossible to call deprecate() on a frozen ParameterBag.');
     }
 
+    /**
+     * @return never
+     */
     public function remove(string $name)
     {
         throw new LogicException('Impossible to call remove() on a frozen ParameterBag.');

ParameterBag/ParameterBag.php

@@ -255,6 +255,9 @@ public function resolveString(string $value, array $resolving = []): mixed
         }, $value);
     }
 
+    /**
+     * @return bool
+     */
     public function isResolved()
     {
         return $this->resolved;

Tests/Fixtures/php/services10_as_files.txt

@@ -93,7 +93,7 @@ class ProjectServiceContainer extends Container
         return require $this->containerDir.\DIRECTORY_SEPARATOR.'removed-ids.php';
     }
 
-    protected function load($file, $lazyLoad = true)
+    protected function load($file, $lazyLoad = true): mixed
     {
         if (class_exists($class = __NAMESPACE__.'\\'.$file, false)) {
             return $class::do($this, $lazyLoad);

Tests/Fixtures/php/services9_as_files.txt

@@ -627,7 +627,7 @@ class ProjectServiceContainer extends Container
         return require $this->containerDir.\DIRECTORY_SEPARATOR.'removed-ids.php';
     }
 
-    protected function load($file, $lazyLoad = true)
+    protected function load($file, $lazyLoad = true): mixed
     {
         if (class_exists($class = __NAMESPACE__.'\\'.$file, false)) {
             return $class::do($this, $lazyLoad);

Tests/Fixtures/php/services_deprecated_parameters_as_files.txt

@@ -73,7 +73,7 @@ class ProjectServiceContainer extends Container
         return true;
     }
 
-    protected function load($file, $lazyLoad = true)
+    protected function load($file, $lazyLoad = true): mixed
     {
         if (class_exists($class = __NAMESPACE__.'\\'.$file, false)) {
             return $class::do($this, $lazyLoad);