[VarExporter] Fix possible memory-leak when using lazy-objects

Author: nicolas-grekas

Dumper/PhpDumper.php

@@ -29,7 +29,6 @@
 use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
 use Symfony\Component\DependencyInjection\Exception\LogicException;
 use Symfony\Component\DependencyInjection\Exception\RuntimeException;
-use Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException;
 use Symfony\Component\DependencyInjection\ExpressionLanguage;
 use Symfony\Component\DependencyInjection\LazyProxy\PhpDumper\DumperInterface as ProxyDumper;
 use Symfony\Component\DependencyInjection\LazyProxy\PhpDumper\LazyServiceDumper;
@@ -168,15 +167,7 @@ public function dump(array $options = []): string|array
 
         if ($this->getProxyDumper() instanceof NullDumper) {
             (new AnalyzeServiceReferencesPass(true, false))->process($this->container);
-            try {
-                (new CheckCircularReferencesPass())->process($this->container);
-            } catch (ServiceCircularReferenceException $e) {
-                $path = $e->getPath();
-                end($path);
-                $path[key($path)] .= '". Try running "composer require symfony/proxy-manager-bridge';
-
-                throw new ServiceCircularReferenceException($e->getServiceId(), $path);
-            }
+            (new CheckCircularReferencesPass())->process($this->container);
         }
 
         $this->analyzeReferences();

Tests/Dumper/PhpDumperTest.php

@@ -765,7 +765,7 @@ public function testCircularReferenceAllowanceForLazyServices()
         $dumper = new PhpDumper($container);
         $dumper->setProxyDumper(new NullDumper());
 
-        $message = 'Circular reference detected for service "foo", path: "foo -> bar -> foo". Try running "composer require symfony/proxy-manager-bridge".';
+        $message = 'Circular reference detected for service "foo", path: "foo -> bar -> foo".';
         $this->expectException(ServiceCircularReferenceException::class);
         $this->expectExceptionMessage($message);
 

composer.json

@@ -31,8 +31,7 @@
         "symfony/yaml": "",
         "symfony/config": "",
         "symfony/finder": "For using double-star glob patterns or when GLOB_BRACE portability is required",
-        "symfony/expression-language": "For using expressions in service container configuration",
-        "symfony/proxy-manager-bridge": "Generate service proxies to lazy load them"
+        "symfony/expression-language": "For using expressions in service container configuration"
     },
     "conflict": {
         "ext-psr": "<1.1|>=2",