Leverage non-capturing catches

Author: fancyweb

Compiler/AttributeAutoconfigurationPass.php

@@ -55,7 +55,7 @@ public function process(ContainerBuilder $container): void
 
             try {
                 $attributeReflector = new \ReflectionClass($attributeName);
-            } catch (\ReflectionException $e) {
+            } catch (\ReflectionException) {
                 continue;
             }
 
@@ -103,7 +103,7 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed
         if ($this->parameterAttributeConfigurators) {
             try {
                 $constructorReflector = $this->getConstructor($value, false);
-            } catch (RuntimeException $e) {
+            } catch (RuntimeException) {
                 $constructorReflector = null;
             }
 

Compiler/AutowireRequiredMethodsPass.php

@@ -73,7 +73,7 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed
                 }
                 try {
                     $r = $r->getPrototype();
-                } catch (\ReflectionException $e) {
+                } catch (\ReflectionException) {
                     break; // method has no prototype
                 }
             }

Compiler/CheckTypeDeclarationsPass.php

@@ -226,7 +226,7 @@ private function checkType(Definition $checkedDefinition, mixed $value, \Reflect
         } elseif ($value instanceof Expression) {
             try {
                 $value = $this->getExpressionLanguage()->evaluate($value, ['container' => $this->container]);
-            } catch (\Exception $e) {
+            } catch (\Exception) {
                 // If a service from the expression cannot be fetched from the container, we skip the validation.
                 return;
             }
@@ -241,7 +241,7 @@ private function checkType(Definition $checkedDefinition, mixed $value, \Reflect
                 if ('' === preg_replace('/'.$envPlaceholderUniquePrefix.'_\w+_[a-f0-9]{32}/U', '', $value, -1, $c) && 1 === $c) {
                     try {
                         $value = $this->container->resolveEnvPlaceholders($value, true);
-                    } catch (\Exception $e) {
+                    } catch (\Exception) {
                         // If an env placeholder cannot be resolved, we skip the validation.
                         return;
                     }

Container.php

@@ -281,7 +281,7 @@ public function reset()
                 if ($service instanceof ResetInterface) {
                     $service->reset();
                 }
-            } catch (\Throwable $e) {
+            } catch (\Throwable) {
                 continue;
             }
         }

Dumper/GraphvizDumper.php

@@ -161,7 +161,7 @@ private function findNodes(): array
 
             try {
                 $class = $this->container->getParameterBag()->resolveValue($class);
-            } catch (ParameterNotFoundException $e) {
+            } catch (ParameterNotFoundException) {
             }
 
             $nodes[$id] = ['class' => str_replace('\\', '\\\\', $class), 'attributes' => array_merge($this->options['node.definition'], ['style' => $definition->isShared() ? 'filled' : 'dotted'])];

Dumper/Preloader.php

@@ -109,7 +109,7 @@ private static function doPreload(string $class, array &$preloaded): void
 
                 self::preloadType($m->getReturnType(), $preloaded);
             }
-        } catch (\Throwable $e) {
+        } catch (\Throwable) {
             // ignore missing classes
         }
     }

EnvVarProcessor.php

@@ -104,7 +104,7 @@ public function getEnv(string $prefix, string $name, \Closure $getEnv): mixed
                 if ('' !== $env && null !== $env) {
                     return $env;
                 }
-            } catch (EnvNotFoundException $e) {
+            } catch (EnvNotFoundException) {
                 // no-op
             }
 
@@ -160,7 +160,7 @@ public function getEnv(string $prefix, string $name, \Closure $getEnv): mixed
                     if ($ended || $count === $i) {
                         $loaders = $this->loaders;
                     }
-                } catch (ParameterCircularReferenceException $e) {
+                } catch (ParameterCircularReferenceException) {
                     // skip loaders that need an env var that is not defined
                 } finally {
                     $this->loaders = $loaders;