Skip to content

Commit 11edaed

Browse files
Revert "bug #29409 Fix env fallback to an unresolved variable (jderusse)"
This reverts commit ab95ae3f7a13c145037196a17b1dc1d2d4cd0399, reversing changes made to 8a6090793b638e32df871f6200ce65c740433d83.
1 parent 50bf074 commit 11edaed

File tree

2 files changed

+4
-22
lines changed

2 files changed

+4
-22
lines changed

ContainerBuilder.php

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1534,15 +1534,11 @@ protected function getEnv($name)
15341534
return $value;
15351535
}
15361536

1537-
$envPlaceholders = $bag->getEnvPlaceholders();
1538-
if (isset($envPlaceholders[$name][$value])) {
1539-
$bag = new ParameterBag($bag->all());
1540-
1541-
return $bag->unescapeValue($bag->get("env($name)"));
1542-
}
1543-
foreach ($envPlaceholders as $env => $placeholders) {
1537+
foreach ($bag->getEnvPlaceholders() as $env => $placeholders) {
15441538
if (isset($placeholders[$value])) {
1545-
return $this->getEnv($env);
1539+
$bag = new ParameterBag($bag->all());
1540+
1541+
return $bag->unescapeValue($bag->get("env($name)"));
15461542
}
15471543
}
15481544

Tests/ContainerBuilderTest.php

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -738,20 +738,6 @@ public function testDynamicEnv()
738738
$this->assertSame('someFooBar', $container->getParameter('baz'));
739739
}
740740

741-
public function testFallbackEnv()
742-
{
743-
putenv('DUMMY_FOO=foo');
744-
745-
$container = new ContainerBuilder();
746-
$container->setParameter('foo', '%env(DUMMY_FOO)%');
747-
$container->setParameter('bar', 'bar%env(default:foo:DUMMY_BAR)%');
748-
749-
$container->compile(true);
750-
putenv('DUMMY_FOO');
751-
752-
$this->assertSame('barfoo', $container->getParameter('bar'));
753-
}
754-
755741
public function testCastEnv()
756742
{
757743
$container = new ContainerBuilder();

0 commit comments

Comments
 (0)