Never rely on dynamic properties

Author: nicolas-grekas

Tests/ContainerBuilderTest.php

@@ -253,7 +253,6 @@ public function testGetServiceIds()
     {
         $builder = new ContainerBuilder();
         $builder->register('foo', 'stdClass');
-        $builder->bar = $bar = new \stdClass();
         $builder->register('bar', 'stdClass');
         $this->assertEquals(
             [

Tests/Fixtures/StdClassDecorator.php

@@ -4,6 +4,8 @@
 
 final class StdClassDecorator
 {
+    public $foo;
+
     public function __construct(\stdClass $foo)
     {
         $this->foo = $foo;

Tests/Fixtures/includes/classes.php

@@ -142,6 +142,8 @@ public static function create($config)
 
 class FoobarCircular
 {
+    public $foo;
+
     public function __construct(FooCircular $foo)
     {
         $this->foo = $foo;
@@ -150,6 +152,8 @@ public function __construct(FooCircular $foo)
 
 class FooCircular
 {
+    public $bar;
+
     public function __construct(BarCircular $bar)
     {
         $this->bar = $bar;
@@ -158,6 +162,8 @@ public function __construct(BarCircular $bar)
 
 class BarCircular
 {
+    public $foobar;
+
     public function addFoobar(FoobarCircular $foobar)
     {
         $this->foobar = $foobar;