Skip to content

Commit 025f792

Browse files
committed
Merge branch '2.6' into 2.7
* 2.6: Fix small coding style [2.3] Static Code Analysis for Components [Form] fixed phpdoc CS: Convert double quotes to single quotes Fixed MongoODM entity loader. Improved loading behavior of entities and documents by reusing entity loader. [Validator] added Japanese translation for unmatched charset (id: 80) [WebProfilerBundle] fixed undefined buttons. [WebProfilerBundle] Fix javascript toolbar on IE8 [DependencyInjection] Highest precedence for user parameters bumped Symfony version to 2.6.6 [Translation][MoFileLoader] fixed load empty translation. updated VERSION for 2.6.5 updated CHANGELOG for 2.6.5 bumped Symfony version to 2.3.27 updated VERSION for 2.3.26 update CONTRIBUTORS for 2.3.26 updated CHANGELOG for 2.3.26 [HttpKernel] UriSigner::buildUrl - default params for http_build_query Conflicts: src/Symfony/Bridge/Propel1/Tests/DataCollector/PropelDataCollectorTest.php src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php src/Symfony/Component/HttpKernel/Kernel.php src/Symfony/Component/Security/Http/Firewall/AbstractPreAuthenticatedListener.php src/Symfony/Component/Validator/Resources/translations/validators.ja.xlf
2 parents 5d856ee + 2b9a962 commit 025f792

File tree

6 files changed

+13
-14
lines changed

6 files changed

+13
-14
lines changed

Compiler/MergeExtensionConfigurationPass.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@ public function process(ContainerBuilder $container)
5555
$extension->load($config, $tmpContainer);
5656

5757
$container->merge($tmpContainer);
58+
$container->getParameterBag()->add($parameters);
5859
}
5960

6061
$container->addDefinitions($definitions);
6162
$container->addAliases($aliases);
62-
$container->getParameterBag()->add($parameters);
6363
}
6464
}

Dumper/GraphvizDumper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ private function findNodes()
180180
foreach ($container->getServiceIds() as $id) {
181181
$service = $container->get($id);
182182

183-
if (in_array($id, array_keys($container->getAliases()))) {
183+
if (array_key_exists($id, $container->getAliases())) {
184184
continue;
185185
}
186186

Dumper/PhpDumper.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,7 @@ private function addService($id, $definition)
560560
if ($definition->isSynthetic()) {
561561
$return[] = '@throws RuntimeException always since this service is expected to be injected dynamically';
562562
} elseif ($class = $definition->getClass()) {
563-
$return[] = sprintf("@return %s A %s instance.", 0 === strpos($class, '%') ? 'object' : "\\".$class, $class);
563+
$return[] = sprintf('@return %s A %s instance.', 0 === strpos($class, '%') ? 'object' : "\\".$class, $class);
564564
} elseif ($definition->getFactory()) {
565565
$factory = $definition->getFactory();
566566
if (is_string($factory)) {
@@ -1340,7 +1340,7 @@ private function dumpValue($value, $interpolate = true)
13401340
} elseif (null !== $value->getFactoryService(false)) {
13411341
$service = $this->dumpValue($value->getFactoryService(false));
13421342

1343-
return sprintf("%s->%s(%s)", 0 === strpos($service, '$') ? sprintf('$this->get(%s)', $service) : $this->getServiceCall($value->getFactoryService(false)), $value->getFactoryMethod(false), implode(', ', $arguments));
1343+
return sprintf('%s->%s(%s)', 0 === strpos($service, '$') ? sprintf('$this->get(%s)', $service) : $this->getServiceCall($value->getFactoryService(false)), $value->getFactoryMethod(false), implode(', ', $arguments));
13441344
} else {
13451345
throw new RuntimeException('Cannot dump definitions which have factory method without factory service or factory class.');
13461346
}

Tests/Compiler/MergeExtensionConfigurationPassTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<?php
22

3-
43
namespace Symfony\Component\DependencyInjection\Tests\Compiler;
54

65
use Symfony\Component\DependencyInjection\Compiler\MergeExtensionConfigurationPass;

Tests/Dumper/PhpDumperTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ public function testDumpOptimizationString()
4848
'.' => 'dot as a key',
4949
'.\'\'.' => 'concatenation as a key',
5050
'\'\'.' => 'concatenation from the start key',
51-
'optimize concatenation' => "string1%some_string%string2",
52-
'optimize concatenation with empty string' => "string1%empty_value%string2",
51+
'optimize concatenation' => 'string1%some_string%string2',
52+
'optimize concatenation with empty string' => 'string1%empty_value%string2',
5353
'optimize concatenation from the start' => '%empty_value%start',
5454
'optimize concatenation at the end' => 'end%empty_value%',
5555
));

Tests/Loader/XmlFileLoaderTest.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -274,31 +274,31 @@ public function testParsesTags()
274274

275275
public function testConvertDomElementToArray()
276276
{
277-
$doc = new \DOMDocument("1.0");
277+
$doc = new \DOMDocument('1.0');
278278
$doc->loadXML('<foo>bar</foo>');
279279
$this->assertEquals('bar', XmlFileLoader::convertDomElementToArray($doc->documentElement), '::convertDomElementToArray() converts a \DomElement to an array');
280280

281-
$doc = new \DOMDocument("1.0");
281+
$doc = new \DOMDocument('1.0');
282282
$doc->loadXML('<foo foo="bar" />');
283283
$this->assertEquals(array('foo' => 'bar'), XmlFileLoader::convertDomElementToArray($doc->documentElement), '::convertDomElementToArray() converts a \DomElement to an array');
284284

285-
$doc = new \DOMDocument("1.0");
285+
$doc = new \DOMDocument('1.0');
286286
$doc->loadXML('<foo><foo>bar</foo></foo>');
287287
$this->assertEquals(array('foo' => 'bar'), XmlFileLoader::convertDomElementToArray($doc->documentElement), '::convertDomElementToArray() converts a \DomElement to an array');
288288

289-
$doc = new \DOMDocument("1.0");
289+
$doc = new \DOMDocument('1.0');
290290
$doc->loadXML('<foo><foo>bar<foo>bar</foo></foo></foo>');
291291
$this->assertEquals(array('foo' => array('value' => 'bar', 'foo' => 'bar')), XmlFileLoader::convertDomElementToArray($doc->documentElement), '::convertDomElementToArray() converts a \DomElement to an array');
292292

293-
$doc = new \DOMDocument("1.0");
293+
$doc = new \DOMDocument('1.0');
294294
$doc->loadXML('<foo><foo></foo></foo>');
295295
$this->assertEquals(array('foo' => null), XmlFileLoader::convertDomElementToArray($doc->documentElement), '::convertDomElementToArray() converts a \DomElement to an array');
296296

297-
$doc = new \DOMDocument("1.0");
297+
$doc = new \DOMDocument('1.0');
298298
$doc->loadXML('<foo><foo><!-- foo --></foo></foo>');
299299
$this->assertEquals(array('foo' => null), XmlFileLoader::convertDomElementToArray($doc->documentElement), '::convertDomElementToArray() converts a \DomElement to an array');
300300

301-
$doc = new \DOMDocument("1.0");
301+
$doc = new \DOMDocument('1.0');
302302
$doc->loadXML('<foo><foo foo="bar"/><foo foo="bar"/></foo>');
303303
$this->assertEquals(array('foo' => array(array('foo' => 'bar'), array('foo' => 'bar'))), XmlFileLoader::convertDomElementToArray($doc->documentElement), '::convertDomElementToArray() converts a \DomElement to an array');
304304
}

0 commit comments

Comments
 (0)