fixed CS

Author: fabpot

Cache/CacheTrait.php

@@ -46,7 +46,7 @@ private function doGet(CacheItemPoolInterface $pool, string $key, callable $call
 
         $item = $pool->getItem($key);
         $recompute = !$item->isHit() || INF === $beta;
-        $metadata = $item instanceof ItemInterface ? $item->getMetadata() : array();
+        $metadata = $item instanceof ItemInterface ? $item->getMetadata() : [];
 
         if (!$recompute && $metadata) {
             $expiry = $metadata[ItemInterface::METADATA_EXPIRY] ?? false;

Service/ServiceLocatorTrait.php

@@ -23,7 +23,7 @@
 trait ServiceLocatorTrait
 {
     private $factories;
-    private $loading = array();
+    private $loading = [];
 
     /**
      * @param callable[] $factories

Service/ServiceSubscriberTrait.php

@@ -32,7 +32,7 @@ public static function getSubscribedServices(): array
             return $services;
         }
 
-        $services = \is_callable(array('parent', __FUNCTION__)) ? parent::getSubscribedServices() : array();
+        $services = \is_callable(['parent', __FUNCTION__]) ? parent::getSubscribedServices() : [];
 
         foreach ((new \ReflectionClass(self::class))->getMethods() as $method) {
             if ($method->isStatic() || $method->isAbstract() || $method->isGenerator() || $method->isInternal() || $method->getNumberOfRequiredParameters()) {
@@ -54,7 +54,7 @@ public function setContainer(ContainerInterface $container)
     {
         $this->container = $container;
 
-        if (\is_callable(array('parent', __FUNCTION__))) {
+        if (\is_callable(['parent', __FUNCTION__])) {
             return parent::setContainer($container);
         }
     }

Tests/Cache/CacheTraitTest.php

@@ -34,7 +34,7 @@ public function testSave()
             ->with('computed data');
 
         $cache = $this->getMockBuilder(TestPool::class)
-            ->setMethods(array('getItem', 'save'))
+            ->setMethods(['getItem', 'save'])
             ->getMock();
         $cache->expects($this->once())
             ->method('getItem')
@@ -60,7 +60,7 @@ public function testNoCallbackCallOnHit()
             ->method('set');
 
         $cache = $this->getMockBuilder(TestPool::class)
-            ->setMethods(array('getItem', 'save'))
+            ->setMethods(['getItem', 'save'])
             ->getMock();
 
         $cache->expects($this->once())
@@ -91,7 +91,7 @@ public function testRecomputeOnBetaInf()
             ->with('computed data');
 
         $cache = $this->getMockBuilder(TestPool::class)
-            ->setMethods(array('getItem', 'save'))
+            ->setMethods(['getItem', 'save'])
             ->getMock();
 
         $cache->expects($this->once())
@@ -111,7 +111,7 @@ public function testRecomputeOnBetaInf()
     public function testExceptionOnNegativeBeta()
     {
         $cache = $this->getMockBuilder(TestPool::class)
-            ->setMethods(array('getItem', 'save'))
+            ->setMethods(['getItem', 'save'])
             ->getMock();
 
         $callback = function (CacheItemInterface $item) {
@@ -135,15 +135,15 @@ public function deleteItem($key)
     {
     }
 
-    public function deleteItems(array $keys = array())
+    public function deleteItems(array $keys = [])
     {
     }
 
     public function getItem($key)
     {
     }
 
-    public function getItems(array $key = array())
+    public function getItems(array $key = [])
     {
     }
 

Tests/Service/ServiceLocatorTest.php

@@ -26,11 +26,11 @@ public function getServiceLocator(array $factories)
 
     public function testHas()
     {
-        $locator = $this->getServiceLocator(array(
+        $locator = $this->getServiceLocator([
             'foo' => function () { return 'bar'; },
             'bar' => function () { return 'baz'; },
             function () { return 'dummy'; },
-        ));
+        ]);
 
         $this->assertTrue($locator->has('foo'));
         $this->assertTrue($locator->has('bar'));
@@ -39,10 +39,10 @@ function () { return 'dummy'; },
 
     public function testGet()
     {
-        $locator = $this->getServiceLocator(array(
+        $locator = $this->getServiceLocator([
             'foo' => function () { return 'bar'; },
             'bar' => function () { return 'baz'; },
-        ));
+        ]);
 
         $this->assertSame('bar', $locator->get('foo'));
         $this->assertSame('baz', $locator->get('bar'));
@@ -51,13 +51,13 @@ public function testGet()
     public function testGetDoesNotMemoize()
     {
         $i = 0;
-        $locator = $this->getServiceLocator(array(
+        $locator = $this->getServiceLocator([
             'foo' => function () use (&$i) {
                 ++$i;
 
                 return 'bar';
             },
-        ));
+        ]);
 
         $this->assertSame('bar', $locator->get('foo'));
         $this->assertSame('bar', $locator->get('foo'));
@@ -70,9 +70,9 @@ public function testGetDoesNotMemoize()
      */
     public function testThrowsOnUndefinedInternalService()
     {
-        $locator = $this->getServiceLocator(array(
+        $locator = $this->getServiceLocator([
             'foo' => function () use (&$locator) { return $locator->get('bar'); },
-        ));
+        ]);
 
         $locator->get('foo');
     }
@@ -83,11 +83,11 @@ public function testThrowsOnUndefinedInternalService()
      */
     public function testThrowsOnCircularReference()
     {
-        $locator = $this->getServiceLocator(array(
+        $locator = $this->getServiceLocator([
             'foo' => function () use (&$locator) { return $locator->get('bar'); },
             'bar' => function () use (&$locator) { return $locator->get('baz'); },
             'baz' => function () use (&$locator) { return $locator->get('bar'); },
-        ));
+        ]);
 
         $locator->get('foo');
     }

Tests/Service/ServiceSubscriberTraitTest.php

@@ -21,14 +21,14 @@ class ServiceSubscriberTraitTest extends TestCase
 {
     public function testMethodsOnParentsAndChildrenAreIgnoredInGetSubscribedServices()
     {
-        $expected = array(TestService::class.'::aService' => '?Symfony\Contracts\Tests\Service\Service2');
+        $expected = [TestService::class.'::aService' => '?Symfony\Contracts\Tests\Service\Service2'];
 
         $this->assertEquals($expected, ChildTestService::getSubscribedServices());
     }
 
     public function testSetContainerIsCalledOnParent()
     {
-        $container = new class(array()) implements ContainerInterface {
+        $container = new class([]) implements ContainerInterface {
             use ServiceLocatorTrait;
         };