Skip to content

Commit fc60649

Browse files
javiereguiluzjaviereguiluz
committed
Update the attributes and classes of code blocks
1 parent 9010b35 commit fc60649

File tree

19 files changed

+32
-32
lines changed

19 files changed

+32
-32
lines changed

‎src/Renderers/CodeNodeRenderer.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,18 +79,18 @@ public function render(): string
7979
}
8080

8181
$numOfLines = \count(preg_split('/\r\n|\r|\n/', $highlightedCode));
82-
$lines = implode("\n", range(1, $numOfLines));
82+
$lineNumbers = implode("\n", range(1, $numOfLines));
8383

8484
return $this->templateRenderer->render(
8585
'code.html.twig',
8686
[
8787
'languages' => $languages,
88-
'lines' => $lines,
88+
'line_numbers' => $lineNumbers,
8989
'code' => $highlightedCode,
90-
// this is the number of digits of the codeblock lines-of-code
91-
// e.g. LOC = 5, digits = 1; LOC = 18, digits = 2
92-
// this is useful to tweak the code listings according to their length
93-
'numLocDigits' => strlen((string) $numOfLines),
90+
'loc' => $numOfLines,
91+
// the length of the codeblock in a semantic way (to tweak styling)
92+
// e.g. LOC = 5, length = 'sm'; LOC = 18, length = 'md'
93+
'length' => [1 => 'sm', 2 => 'md', 3 => 'lg', 4 => 'xl'][strlen((string) $numOfLines)],
9494
]
9595
);
9696
}

‎src/Templates/default/html/code.html.twig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
<div translate="no" class="notranslate codeblock codeblock-loc-{{ numLocDigits }} {{ languages|map(language => "codeblock-#{language}")|join(' ') }}">
1+
<div translate="no" data-loc="{{ loc }}" class="notranslate codeblock codeblock-length-{{ length }} {{ languages|map(language => "codeblock-#{language}")|join(' ') }}">
22
<div class="codeblock-scroll">
3-
<pre class="codeblock-lines">{{ lines }}</pre>
3+
<pre class="codeblock-lines">{{ line_numbers }}</pre>
44
<pre class="codeblock-code"><code>{{ code|raw }}</code></pre>
55
</div>
66
</div>

‎tests/fixtures/expected/blocks/code-blocks/bash.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div translate="no" class="notranslate codeblock codeblock-loc-1 codeblock-bash">
1+
<div translate="no" data-loc="1" class="notranslate codeblock codeblock-length-sm codeblock-bash">
22
<div class="codeblock-scroll">
33
<pre class="codeblock-lines">1</pre>
44
<pre class="codeblock-code"><code>git <span class="hljs-built_in">clone</span> git@github.com:symfony/symfony.git</code></pre>

‎tests/fixtures/expected/blocks/code-blocks/html-php.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div translate="no" class="notranslate codeblock codeblock-loc-2 codeblock-html+php codeblock-html">
1+
<div translate="no" data-loc="12" class="notranslate codeblock codeblock-length-md codeblock-html+php codeblock-html">
22
<div class="codeblock-scroll">
33
<pre class="codeblock-lines">1
44
2

‎tests/fixtures/expected/blocks/code-blocks/html-twig.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div translate="no" class="notranslate codeblock codeblock-loc-1 codeblock-html+twig codeblock-twig">
1+
<div translate="no" data-loc="2" class="notranslate codeblock codeblock-length-sm codeblock-html+twig codeblock-twig">
22
<div class="codeblock-scroll">
33
<pre class="codeblock-lines">1
44
2</pre>

‎tests/fixtures/expected/blocks/code-blocks/html.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div translate="no" class="notranslate codeblock codeblock-loc-1 codeblock-html">
1+
<div translate="no" data-loc="1" class="notranslate codeblock codeblock-length-sm codeblock-html">
22
<div class="codeblock-scroll">
33
<pre class="codeblock-lines">1</pre>
44
<pre class="codeblock-code"><code><span class="hljs-comment">&lt;!-- some code --&gt;</span>

‎tests/fixtures/expected/blocks/code-blocks/ini.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div translate="no" class="notranslate codeblock codeblock-loc-1 codeblock-ini">
1+
<div translate="no" data-loc="1" class="notranslate codeblock codeblock-length-sm codeblock-ini">
22
<div class="codeblock-scroll">
33
<pre class="codeblock-lines">1</pre>
44
<pre class="codeblock-code"><code><span class="hljs-attr">fetch</span> = +refs/notes/*:refs/notes/*</code></pre>

‎tests/fixtures/expected/blocks/code-blocks/php-annotations.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div translate="no" class="notranslate codeblock codeblock-loc-2 codeblock-php-annotations codeblock-php">
1+
<div translate="no" data-loc="14" class="notranslate codeblock codeblock-length-md codeblock-php-annotations codeblock-php">
22
<div class="codeblock-scroll">
33
<pre class="codeblock-lines">1
44
2

‎tests/fixtures/expected/blocks/code-blocks/php.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div translate="no" class="notranslate codeblock codeblock-loc-1 codeblock-php">
1+
<div translate="no" data-loc="7" class="notranslate codeblock codeblock-length-sm codeblock-php">
22
<div class="codeblock-scroll">
33
<pre class="codeblock-lines">1
44
2

‎tests/fixtures/expected/blocks/code-blocks/terminal.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
<div translate="no" class="notranslate codeblock codeblock-loc-1 codeblock-terminal codeblock-bash">
1+
<div translate="no" data-loc="1" class="notranslate codeblock codeblock-length-sm codeblock-terminal codeblock-bash">
22
<div class="codeblock-scroll">
33
<pre class="codeblock-lines">1</pre>
44
<pre class="codeblock-code"><code>git <span
55
class="hljs-built_in">clone</span> git@github.com:symfony/symfony.git</code></pre>
66
</div>
77
</div>
8-
<div translate="no" class="notranslate codeblock codeblock-loc-1 codeblock-terminal codeblock-bash">
8+
<div translate="no" data-loc="2" class="notranslate codeblock codeblock-length-sm codeblock-terminal codeblock-bash">
99
<div class="codeblock-scroll">
1010
<pre class="codeblock-lines">1
1111
2</pre>
@@ -20,7 +20,7 @@
2020
</div>
2121
</div>
2222

23-
<div translate="no" class="notranslate codeblock codeblock-loc-1 codeblock-terminal codeblock-bash">
23+
<div translate="no" data-loc="3" class="notranslate codeblock codeblock-length-sm codeblock-terminal codeblock-bash">
2424
<div class="codeblock-scroll">
2525
<pre class="codeblock-lines">1
2626
2

0 commit comments

Comments
 (0)