tweaking release process

Author: weaverryan

.env.dist

@@ -4,29 +4,15 @@
 require __DIR__.'/../vendor/autoload.php';
 
 use SymfonyDocsBuilder\Phar\Compiler;
-use SymfonyDocsBuilder\Release\Exception\ReleaseFailed;
 use SymfonyDocsBuilder\Release\GithubApiHttpClientFactory;
 use SymfonyDocsBuilder\Release\Releaser;
 
-error_reporting(-1);
-ini_set('display_errors', 1);
+if ($argc !== 4) {
+    echo 'Not enough arguments. usage: "./bin/release tag [release_name [release_description]]"';
+    echo "\n\n";
 
-try {
-    $releaser = new Releaser((new GithubApiHttpClientFactory())->createHttpClient(), new Compiler());
-
-    if ($argc === 1) {
-        throw new RuntimeException('Not enough arguments. usage: "./bin/release tag [release_name [release_description]]"');
-    }
-
-    array_shift($argv);
-
-    $releaser->createRelease(...$argv);
-} catch (Exception $e) {
-    if ($e instanceof ReleaseFailed) {
-        echo $e->toString();
-    } else {
-        echo 'Failed to create a new release: ['.get_class($e).'] '.$e->getMessage().' at '.$e->getFile().':'.$e->getLine()."\n";
-    }
-
-    exit(1);
+    return 1;
 }
+
+$releaser = new Releaser((new GithubApiHttpClientFactory())->createHttpClient(), new Compiler());
+$releaser->createRelease($argv[1], $argv[2], $argv[3]);

bin/create_release

@@ -25,7 +25,6 @@
     "require-dev": {
         "gajus/dindent": "^2.0",
         "symfony/phpunit-bridge": "^4.1",
-        "symfony/process": "^4.2",
-        "symfony/dotenv": "^4.3"
+        "symfony/process": "^4.2"
     }
 }

composer.json

@@ -2,7 +2,6 @@
 
 namespace SymfonyDocsBuilder\Release;
 
-use Symfony\Component\Dotenv\Dotenv;
 use Symfony\Component\HttpClient\HttpClient;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 
@@ -12,11 +11,8 @@ class GithubApiHttpClientFactory
 
     public function __construct()
     {
-        $dotenv = new Dotenv();
-        $dotenv->load(__DIR__.'/../../.env');
-
-        if (empty($_SERVER['GITHUB_API_TOKEN'])) {
-            throw new \RuntimeException('Please fill "GITHUB_API_TOKEN" in file "[PROJECT_DIR]/.env"');
+        if (!isset($_SERVER['GITHUB_API_TOKEN'])) {
+            throw new \RuntimeException('Missing "GITHUB_API_TOKEN" environment variable');
         }
 
         $this->githubApiToken = $_SERVER['GITHUB_API_TOKEN'];

composer.lock

@@ -5,6 +5,7 @@
 use Symfony\Contracts\HttpClient\Exception\HttpExceptionInterface;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 use SymfonyDocsBuilder\Phar\Compiler;
+use SymfonyDocsBuilder\Release\Exception\DeleteReleaseFailed;
 use SymfonyDocsBuilder\Release\Exception\ReleaseFailed;
 
 class Releaser