Converting to using service ids, simply so anyone can create susbcribers for anything and control their own deps

Author: weaverryan

app/config/github.yml

@@ -1,12 +1,19 @@
+# listener services that you can opt into for a repository
+services:
+    app.subscriber.issue_subscriber:
+        class: AppBundle\Issues\IssueListener
+        arguments:
+            - '@app.status_api.default'
+
 parameters:
     # defines symfony repository as default
     default_repository: symfony/symfony
 
     # point to the main symfony repositories
     repositories:
         symfony/symfony:
-            listeners:
-                - AppBundle\Listener\SymfonyIssueListener
+            subscribers:
+                - app.subscriber.issue_subscriber
             maintainers:
                 - fabpot
                 - webmozart
@@ -21,8 +28,8 @@ parameters:
                 - javiereguiluz
             secret: change_me
         symfony/symfony-docs:
-            listeners:
-                - AppBundle\Listener\SymfonyDocsIssueListener
+            subscribers:
+                - app.subscriber.issue_subscriber
             maintainers:
                 - weaverryan
                 - WouterJ

app/config/services.yml

@@ -32,10 +32,10 @@ services:
 
     app.github.request_handler:
         class: AppBundle\Issues\GitHubRequestHandler
-        arguments: ['@app.github.labels_api', '@event_dispatcher', '%repositories%']
+        arguments: ['@app.github.labels_api', '@event_dispatcher', '%repositories%', '@service_container']
 
     app.github.exception_listener:
-        class: Appbundle\Listener\GitHubExceptionListener
+        class: AppBundle\Listener\GitHubExceptionListener
         arguments: ['%kernel.debug%']
         tags:
             - { name: kernel.event_subscriber }

src/AppBundle/Issues/GitHubRequestHandler.php

@@ -12,11 +12,12 @@
 use AppBundle\Issues\GitHub\CachedLabelsApi;
 use AppBundle\Issues\GitHub\GitHubStatusApi;
 use Github\Api\Issue\Labels;
+use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\HttpFoundation\Request;
 
 /**
- * Class GitHubRequestHandler.
+ * Handles GitHub webhook requests
  *
  * @author Jules Pietri <jules@heahprod.com>
  */
@@ -25,15 +26,21 @@ class GitHubRequestHandler
     private $labelsApi;
     private $dispatcher;
     private $repositories;
+    /**
+     * @var ContainerInterface
+     */
+    private $container;
 
-    public function __construct(Labels $labelsApi, EventDispatcherInterface $dispatcher, array $repositories)
+    public function __construct(Labels $labelsApi, EventDispatcherInterface $dispatcher, array $repositories, ContainerInterface $container)
     {
         $this->labelsApi = $labelsApi;
         $this->dispatcher = $dispatcher;
         $this->repositories = $repositories;
+        $this->container = $container;
     }
 
     /**
+     * @param Request $request
      * @return array The response data
      *
      * @throws GitHubExceptionInterface When the request or the configuration are invalid
@@ -63,20 +70,12 @@ public function handle(Request $request)
                 throw new GitHubAccessDeniedException('Invalid signature.');
             }
         }
-        if (empty($config['listeners'])) {
-            throw new GitHubInvalidConfigurationException('The repository "%s" has no listeners configured.');
+        if (empty($config['subscribers'])) {
+            throw new GitHubInvalidConfigurationException('The repository "%s" has no subscribers configured.');
         }
 
-        $api = new GitHubStatusApi(
-            new CachedLabelsApi($this->labelsApi, $repository),
-            $repository
-        );
-        foreach ($config['listeners'] as $listener) {
-            if (!is_subclass_of($listener, __NAMESPACE__.'\IssueListener')) {
-                throw new GitHubInvalidConfigurationException(sprintf('The listener "%s" must be an instance of "\AppBundle\Issues\IssueListener".', $listener));
-            }
-
-            $this->dispatcher->addSubscriber(new $listener($api));
+        foreach ($config['subscribers'] as $subscriberId) {
+            $this->dispatcher->addSubscriber($this->container->get($subscriberId));
         }
 
         $event = new GitHubEvent($data, $repository, $config['maintainers']);