Splitting the IssueListener into 2 different "features"

Author: weaverryan

app/config/github.yml

@@ -1,7 +1,17 @@
 # listener services that you can opt into for a repository
 services:
-    app.subscriber.issue_subscriber:
-        class: AppBundle\Issues\IssueListener
+    app.subscriber.status_change_by_comment_subscriber:
+        class: AppBundle\Subscriber\StatusChangeByCommentSubscriber
+        arguments:
+            - '@app.status_api'
+
+    app.subscriber.needs_review_new_pr_subscriber:
+        class: AppBundle\Subscriber\NeedsReviewNewPRSubscriber
+        arguments:
+            - '@app.status_api'
+
+    app.subscriber.bug_label_new_issue_subscriber:
+        class: AppBundle\Subscriber\BugLabelNewIssueSubscriber
         arguments:
             - '@app.status_api'
 
@@ -10,8 +20,12 @@ parameters:
     repositories:
         symfony/symfony:
             subscribers:
-                - app.subscriber.issue_subscriber
+                - app.subscriber.status_change_by_comment_subscriber
+                - app.subscriber.needs_review_new_pr_subscriber
+                - app.subscriber.bug_label_new_issue_subscriber
             # secret: change_me
         symfony/symfony-docs:
             subscribers:
-                - app.subscriber.issue_subscriber
+                - app.subscriber.status_change_by_comment_subscriber
+                - app.subscriber.needs_review_new_pr_subscriber
+                - app.subscriber.bug_label_new_issue_subscriber

src/AppBundle/Issues/IssueListener.php

@@ -0,0 +1,62 @@
+<?php
+
+namespace AppBundle\Subscriber;
+
+use AppBundle\Event\GitHubEvent;
+use AppBundle\GitHubEvents;
+use AppBundle\Issues\Status;
+use AppBundle\Issues\StatusApi;
+use Symfony\Component\EventDispatcher\EventSubscriberInterface;
+
+class BugLabelNewIssueSubscriber implements EventSubscriberInterface
+{
+    /**
+     * @var StatusApi
+     */
+    private $statusApi;
+
+    public function __construct(StatusApi $statusApi)
+    {
+        $this->statusApi = $statusApi;
+    }
+
+    /**
+     * Changes "Bug" issues to "Needs Review".
+     *
+     * @param GitHubEvent $event
+     */
+    public function onIssues(GitHubEvent $event)
+    {
+        $data = $event->getData();
+        $repository = $event->getRepository();
+        if ('labeled' !== $action = $data['action']) {
+            $event->setResponseData(array('unsupported_action' => $action));
+
+            return;
+        }
+
+        $responseData = array('issue' => $issueNumber = $data['issue']['number']);
+        // Ignore non-bugs or issue which already has a status
+        $currentStatus = $currentStatus = $this->statusApi->getIssueStatus($issueNumber, $repository);
+        if ('bug' !== strtolower($data['label']['name']) || null !== $currentStatus) {
+            $responseData['status_change'] = null;
+            $event->setResponseData($responseData);
+
+            return;
+        }
+
+        $newStatus = Status::NEEDS_REVIEW;
+
+        $this->statusApi->setIssueStatus($issueNumber, $newStatus, $repository);
+        $responseData['status_change'] = $newStatus;
+
+        $event->setResponseData($responseData);
+    }
+
+    public static function getSubscribedEvents()
+    {
+        return array(
+            GitHubEvents::ISSUES => 'onIssues',
+        );
+    }
+}

src/AppBundle/Subscriber/BugLabelNewIssueSubscriber.php

@@ -0,0 +1,52 @@
+<?php
+
+namespace AppBundle\Subscriber;
+
+use AppBundle\Event\GitHubEvent;
+use AppBundle\GitHubEvents;
+use AppBundle\Issues\Status;
+use AppBundle\Issues\StatusApi;
+use Symfony\Component\EventDispatcher\EventSubscriberInterface;
+
+class NeedsReviewNewPRSubscriber implements EventSubscriberInterface
+{
+    private $statusApi;
+
+    public function __construct(StatusApi $statusApi)
+    {
+        $this->statusApi = $statusApi;
+    }
+
+    /**
+     * Adds a "Needs Review" label to new PRs.
+     *
+     * @param GitHubEvent $event
+     */
+    public function onPullRequest(GitHubEvent $event)
+    {
+        $data = $event->getData();
+        $repository = $event->getRepository();
+        if ('opened' !== $action = $data['action']) {
+            $event->setResponseData(array('unsupported_action' => $action));
+
+            return;
+        }
+
+        $pullRequestNumber = $data['pull_request']['number'];
+        $newStatus = Status::NEEDS_REVIEW;
+
+        $this->statusApi->setIssueStatus($pullRequestNumber, $newStatus, $repository);
+
+        $event->setResponseData(array(
+            'pull_request' => $pullRequestNumber,
+            'status_change' => $newStatus,
+        ));
+    }
+
+    public static function getSubscribedEvents()
+    {
+        return array(
+            GitHubEvents::PULL_REQUEST => 'onPullRequest',
+        );
+    }
+}

src/AppBundle/Subscriber/NeedsReviewNewPRSubscriber.php

@@ -0,0 +1,66 @@
+<?php
+
+namespace AppBundle\Subscriber;
+
+use AppBundle\Event\GitHubEvent;
+use AppBundle\GitHubEvents;
+use AppBundle\Issues\Status;
+use AppBundle\Issues\StatusApi;
+use Symfony\Component\EventDispatcher\EventSubscriberInterface;
+
+class StatusChangeByCommentSubscriber implements EventSubscriberInterface
+{
+    private static $triggerWordToStatus = [
+        'needs review' => Status::NEEDS_REVIEW,
+        'needs work' => Status::NEEDS_WORK,
+        'works for me' => Status::WORKS_FOR_ME,
+        'reviewed' => Status::REVIEWED,
+        'needs comments' => Status::NEEDS_COMMENTS,
+    ];
+
+    private $statusApi;
+
+    public function __construct(StatusApi $statusApi)
+    {
+        $this->statusApi = $statusApi;
+    }
+
+    /**
+     * Parses the text of the comment and looks for keywords to see
+     * if this should cause any status change.
+     *
+     * @param GitHubEvent $event
+     */
+    public function onIssueComment(GitHubEvent $event)
+    {
+        $data = $event->getData();
+        $repository = $event->getRepository();
+        $newStatus = null;
+        $issueNumber = $data['issue']['number'];
+
+        $triggerWord = implode('|', array_keys(static::$triggerWordToStatus));
+        $formatting = '[\\s\\*]*';
+        // Match first character after "status:"
+        // Case insensitive ("i"), ignores formatting with "*" before or after the ":"
+        $pattern = "~(?=\n|^)${formatting}status${formatting}:${formatting}[\"']?($triggerWord)[\"']?${formatting}[.!]?${formatting}(?<=\r\n|\n|$)~i";
+
+        if (preg_match_all($pattern, $data['comment']['body'], $matches)) {
+            // Second subpattern = first status character
+            $newStatus = static::$triggerWordToStatus[strtolower(end($matches[1]))];
+
+            $this->statusApi->setIssueStatus($issueNumber, $newStatus, $repository);
+        }
+
+        $event->setResponseData(array(
+            'issue' => $issueNumber,
+            'status_change' => $newStatus,
+        ));
+    }
+
+    public static function getSubscribedEvents()
+    {
+        return array(
+            GitHubEvents::ISSUE_COMMENT => 'onIssueComment',
+        );
+    }
+}