[WIP] Addition of the Repository provider and the Repository object

Author: weaverryan

app/config/github.yml

@@ -6,9 +6,6 @@ services:
             - '@app.status_api.default'
 
 parameters:
-    # defines symfony repository as default
-    default_repository: symfony/symfony
-
     # point to the main symfony repositories
     repositories:
         symfony/symfony:

app/config/services.yml

@@ -32,10 +32,14 @@ services:
 
     app.github.request_handler:
         class: AppBundle\Issues\GitHubRequestHandler
-        arguments: ['@app.github.labels_api', '@event_dispatcher', '%repositories%', '@service_container']
+        arguments: ['@app.github.labels_api', '@event_dispatcher', '@app.repository_provider', '@service_container']
 
     app.github.exception_listener:
         class: AppBundle\Listener\GitHubExceptionListener
         arguments: ['%kernel.debug%']
         tags:
             - { name: kernel.event_subscriber }
+
+    app.repository_provider:
+        class: AppBundle\Repository\Provider\InMemoryRepositoryProvider
+        arguments: [ '%repositories%' ]

src/AppBundle/Issues/GitHubRequestHandler.php

@@ -11,6 +11,8 @@
 use AppBundle\Exception\GitHubRuntimeException;
 use AppBundle\Issues\GitHub\CachedLabelsApi;
 use AppBundle\Issues\GitHub\GitHubStatusApi;
+use AppBundle\Repository\Provider\RepositoryProviderInterface;
+use AppBundle\Repository\RepositoryRegistry;
 use Github\Api\Issue\Labels;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
@@ -25,17 +27,17 @@ class GitHubRequestHandler
 {
     private $labelsApi;
     private $dispatcher;
-    private $repositories;
+    private $repositoryProvider;
     /**
      * @var ContainerInterface
      */
     private $container;
 
-    public function __construct(Labels $labelsApi, EventDispatcherInterface $dispatcher, array $repositories, ContainerInterface $container)
+    public function __construct(Labels $labelsApi, EventDispatcherInterface $dispatcher, RepositoryProviderInterface $repositoryProvider, ContainerInterface $container)
     {
         $this->labelsApi = $labelsApi;
         $this->dispatcher = $dispatcher;
-        $this->repositories = $repositories;
+        $this->repositoryProvider = $repositoryProvider;
         $this->container = $container;
     }
 
@@ -52,33 +54,31 @@ public function handle(Request $request)
             throw new GitHubBadRequestException('Invalid JSON body!');
         }
 
-        $repository = isset($data['repository']['full_name']) ? $data['repository']['full_name'] : null;
-        if (empty($repository)) {
+        $repositoryFullName = isset($data['repository']['full_name']) ? $data['repository']['full_name'] : null;
+        if (empty($repositoryFullName)) {
             throw new GitHubBadRequestException('No repository name!');
         }
 
-        if (!isset($this->repositories[$repository])) {
-            throw new GitHubPreconditionFailedException(sprintf('Unsupported repository "%s".', $repository));
+        $repository = $this->repositoryProvider->getRepository($repositoryFullName);
+
+        if (!$repository) {
+            throw new GitHubPreconditionFailedException(sprintf('Unsupported repository "%s".', $repositoryFullName));
         }
 
-        $config = $this->repositories[$repository];
-        if (isset($config['secret'])) {
+        if ($repository->getSecret()) {
             if (!$request->headers->has('X-Hub-Signature')) {
                 throw new GitHubAccessDeniedException('The request is not secured.');
             }
-            if (!$this->authenticate($request->headers->get('X-Hub-Signature'), $config['secret'], $request->getContent())) {
+            if (!$this->authenticate($request->headers->get('X-Hub-Signature'), $repository->getSecret(), $request->getContent())) {
                 throw new GitHubAccessDeniedException('Invalid signature.');
             }
         }
-        if (empty($config['subscribers'])) {
-            throw new GitHubInvalidConfigurationException('The repository "%s" has no subscribers configured.');
-        }
 
-        foreach ($config['subscribers'] as $subscriberId) {
+        foreach ($repository->getSubscribers() as $subscriberId) {
             $this->dispatcher->addSubscriber($this->container->get($subscriberId));
         }
 
-        $event = new GitHubEvent($data, $repository, $config['maintainers']);
+        $event = new GitHubEvent($data, $repository);
         $eventName = $request->headers->get('X-Github-Event');
 
         try {

src/AppBundle/Repository/Provider/InMemoryRepositoryProvider.php

@@ -0,0 +1,48 @@
+<?php
+
+namespace AppBundle\Repository\Provider;
+
+use AppBundle\Repository\Repository;
+
+/**
+ * @author Ener-Getick <egetick@gmail.com>
+ */
+class InMemoryRepositoryProvider implements RepositoryProviderInterface
+{
+    private $repositories = array();
+
+    public function __construct(array $repositories)
+    {
+        foreach ($repositories as $repositoryFullName => $repositoryData) {
+            if (1 !== substr_count($repositoryFullName, '/')) {
+                throw new \InvalidArgumentException(sprintf('The repository name %s is invalid: it must be the form "username/repo_name"', $repositoryFullName));
+            }
+
+            list($vendorName, $repositoryName) = explode('/', $repositoryFullName);
+
+            if (!isset($repositoryData['subscribers'])) {
+                throw new \InvalidArgumentException(sprintf('The repository %s is missing a subscribers key!', $repositoryFullName));
+            }
+
+            if (empty($repositoryData['subscribers'])) {
+                throw new \InvalidArgumentException(sprintf('The repository "%s" has no subscribers configured.', $repositoryFullName));
+            }
+
+            $this->addRepository(new Repository(
+                $vendorName,
+                $repositoryName,
+                $repositoryData['subscribers']
+            ));
+        }
+    }
+
+    public function getRepository($repositoryName)
+    {
+        return isset($this->repositories[$repositoryName]) ? $this->repositories[$repositoryName] : null;
+    }
+
+    private function addRepository(Repository $repository)
+    {
+        $this->repositories[strtolower($repository->getVendor().'/'.$repository->getName())] = $repository;
+    }
+}

src/AppBundle/Repository/Provider/RepositoryProviderInterface.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace AppBundle\Repository\Provider;
+
+use AppBundle\Repository\Repository;
+
+/**
+ * @author Ener-Getick <egetick@gmail.com>
+ */
+interface RepositoryProviderInterface
+{
+    /**
+     * @param string $repositoryName e.g. symfony/symfony-docs
+     *
+     * @return Repository
+     */
+    public function getRepository($repositoryName);
+}

src/AppBundle/Repository/Repository.php

@@ -0,0 +1,84 @@
+<?php
+
+namespace AppBundle\Repository;
+
+/**
+ * @author Ener-Getick <egetick@gmail.com>
+ */
+class Repository
+{
+    /**
+     * @var string
+     */
+    private $vendor;
+
+    /**
+     * @var string
+     */
+    private $name;
+
+    /**
+     * An array of subscriber service ids
+     *
+     * @var array
+     */
+    private $subscribers;
+
+    public function __construct($vendor, $name, array $subscribers)
+    {
+        $this->vendor = $vendor;
+        $this->name = $name;
+        $this->subscribers = $subscribers;
+    }
+
+    /**
+     * @return string
+     */
+    public function getVendor()
+    {
+        return $this->vendor;
+    }
+
+    /**
+     * @param string $vendor
+     */
+    public function setVendor($vendor)
+    {
+        $this->vendor = $vendor;
+    }
+
+    /**
+     * @return string
+     */
+    public function getName()
+    {
+        return $this->name;
+    }
+
+    /**
+     * @param string $name
+     */
+    public function setName($name)
+    {
+        $this->name = $name;
+    }
+
+    public function getSubscribers()
+    {
+        return $this->subscribers;
+    }
+
+    /**
+     * @return string
+     */
+    public function getSecret()
+    {
+        // todo - implement setting a secret
+    }
+
+    public function getMaintainers()
+    {
+        // todo - implement this
+        return [];
+    }
+}