bug #144 Fixed "stalled" (Nyholm)

This PR was squashed before being merged into the master branch.

Discussion
----------

Fixed "stalled"

This is just fixing a typo

Commits
-------

571a864 Fixed "stalled"

Author: weaverryan

README.md

@@ -78,7 +78,7 @@ review process and how to increase the chances to get the PR merged.
 
 Carson will look for old inactive issues and start a process with them.
 
-1. Bot will make a comment to encourage activity and add label "Staled".
+1. Bot will make a comment to encourage activity and add label "Stalled".
 1. Bot will make a comment to inform the issue will be closed
 1. Bot will close the issue.
 

config/services.yaml

@@ -11,7 +11,7 @@ parameters:
                 - 'App\Subscriber\MilestoneNewPRSubscriber'
                 - 'App\Subscriber\WelcomeFirstTimeContributorSubscriber'
                 - 'App\Subscriber\CloseDraftPRSubscriber'
-                - 'App\Subscriber\RemoveStaledLabelOnCommentSubscriber'
+                - 'App\Subscriber\RemoveStalledLabelOnCommentSubscriber'
             secret: '%env(SYMFONY_SECRET)%'
 
         symfony/symfony-docs:
@@ -24,7 +24,7 @@ parameters:
                 - 'App\Subscriber\BugLabelNewIssueSubscriber'
                 - 'App\Subscriber\AutoLabelFromContentSubscriber'
                 - 'subscriber.symfony_docs.milestone'
-                - 'App\Subscriber\RemoveStaledLabelOnCommentSubscriber'
+                - 'App\Subscriber\RemoveStalledLabelOnCommentSubscriber'
             secret: '%env(SYMFONY_DOCS_SECRET)%'
 
         # used in a functional test
@@ -40,7 +40,7 @@ parameters:
                 - 'App\Subscriber\MilestoneNewPRSubscriber'
                 - 'App\Subscriber\WelcomeFirstTimeContributorSubscriber'
                 - 'App\Subscriber\CloseDraftPRSubscriber'
-                - 'App\Subscriber\RemoveStaledLabelOnCommentSubscriber'
+                - 'App\Subscriber\RemoveStalledLabelOnCommentSubscriber'
 
 services:
     _defaults:

src/Command/PingStaleIssuesCommand.php

@@ -75,7 +75,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         foreach ($issues as $issue) {
             $comment = $this->commentGenerator->getComment($this->extractType($issue));
             $this->issueApi->commentOnIssue($repository, $issue['number'], $comment);
-            $this->labelApi->addIssueLabel($issue['number'], 'Staled', $repository);
+            $this->labelApi->addIssueLabel($issue['number'], 'Stalled', $repository);
 
             // add a scheduled task to process this issue again after 2 weeks
             $this->scheduler->runLater($repository, $issue['number'], Task::ACTION_INFORM_CLOSE_STALE, new \DateTimeImmutable(self::MESSAGE_TWO_AFTER));

src/Service/TaskHandler/CloseStaleIssuesHandler.php

@@ -38,7 +38,7 @@ public function handle(Task $task): void
         }
         $labels = $this->labelApi->getIssueLabels($task->getNumber(), $repository);
         if (in_array('Keep open', $labels)) {
-            $this->labelApi->removeIssueLabel($task->getNumber(), 'Staled', $repository);
+            $this->labelApi->removeIssueLabel($task->getNumber(), 'Stalled', $repository);
 
             return;
         }
@@ -47,7 +47,7 @@ public function handle(Task $task): void
             $this->issueApi->commentOnIssue($repository, $task->getNumber(), $this->commentGenerator->getClosingComment());
             $this->issueApi->close($repository, $task->getNumber());
         } else {
-            $this->labelApi->removeIssueLabel($task->getNumber(), 'Staled', $repository);
+            $this->labelApi->removeIssueLabel($task->getNumber(), 'Stalled', $repository);
         }
     }
 

src/Service/TaskHandler/InformAboutClosingStaleIssuesHandler.php

@@ -42,7 +42,7 @@ public function handle(Task $task): void
         }
         $labels = $this->labelApi->getIssueLabels($task->getNumber(), $repository);
         if (in_array('Keep open', $labels)) {
-            $this->labelApi->removeIssueLabel($task->getNumber(), 'Staled', $repository);
+            $this->labelApi->removeIssueLabel($task->getNumber(), 'Stalled', $repository);
 
             return;
         }
@@ -51,7 +51,7 @@ public function handle(Task $task): void
             $this->issueApi->commentOnIssue($repository, $task->getNumber(), $this->commentGenerator->getInformAboutClosingComment());
             $this->scheduler->runLater($repository, $task->getNumber(), Task::ACTION_CLOSE_STALE, new \DateTimeImmutable(PingStaleIssuesCommand::MESSAGE_THREE_AND_CLOSE_AFTER));
         } else {
-            $this->labelApi->removeIssueLabel($task->getNumber(), 'Staled', $repository);
+            $this->labelApi->removeIssueLabel($task->getNumber(), 'Stalled', $repository);
         }
     }
 

src/Subscriber/RemoveStaledLabelOnCommentSubscriber.php renamed to src/Subscriber/RemoveStalledLabelOnCommentSubscriber.php

@@ -13,7 +13,7 @@
  *
  * @author Tobias Nyholm <tobias.nyholm@gmail.com>
  */
-class RemoveStaledLabelOnCommentSubscriber implements EventSubscriberInterface
+class RemoveStalledLabelOnCommentSubscriber implements EventSubscriberInterface
 {
     private $labelApi;
     private $botUsername;
@@ -37,16 +37,16 @@ public function onIssueComment(GitHubEvent $event)
         $removed = false;
         $issueNumber = $data['issue']['number'];
         foreach ($data['issue']['labels'] as $label) {
-            if ('Staled' === $label['name']) {
+            if ('Stalled' === $label['name']) {
                 $removed = true;
-                $this->labelApi->removeIssueLabel($issueNumber, 'Staled', $repository);
+                $this->labelApi->removeIssueLabel($issueNumber, 'Stalled', $repository);
             }
         }
 
         if ($removed) {
             $event->setResponseData([
                 'issue' => $issueNumber,
-                'removed_staled_label' => true,
+                'removed_stalled_label' => true,
             ]);
         }
     }

tests/Subscriber/RemoveStaledLabelOnCommentSubscriberTest.php renamed to tests/Subscriber/RemoveStalledLabelOnCommentSubscriberTest.php

@@ -8,11 +8,11 @@
 use App\Event\GitHubEvent;
 use App\GitHubEvents;
 use App\Model\Repository;
-use App\Subscriber\RemoveStaledLabelOnCommentSubscriber;
+use App\Subscriber\RemoveStalledLabelOnCommentSubscriber;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\EventDispatcher\EventDispatcher;
 
-class RemoveStaledLabelOnCommentSubscriberTest extends TestCase
+class RemoveStalledLabelOnCommentSubscriberTest extends TestCase
 {
     private $subscriber;
 
@@ -25,7 +25,7 @@ class RemoveStaledLabelOnCommentSubscriberTest extends TestCase
 
     protected function setUp()
     {
-        $this->subscriber = new RemoveStaledLabelOnCommentSubscriber(new NullLabelApi(), 'carsonbot');
+        $this->subscriber = new RemoveStalledLabelOnCommentSubscriber(new NullLabelApi(), 'carsonbot');
         $this->repository = new Repository('carsonbot-playground', 'symfony', null);
 
         $this->dispatcher = new EventDispatcher();
@@ -47,21 +47,21 @@ public function testOnComment()
     public function testOnCommentOnStale()
     {
         $event = new GitHubEvent([
-            'issue' => ['number' => 1234, 'labels' => [['name' => 'Foo'], ['name' => 'Staled']]], 'comment' => ['user' => ['login' => 'nyholm']],
+            'issue' => ['number' => 1234, 'labels' => [['name' => 'Foo'], ['name' => 'Stalled']]], 'comment' => ['user' => ['login' => 'nyholm']],
         ], $this->repository);
 
         $this->dispatcher->dispatch($event, GitHubEvents::ISSUE_COMMENT);
 
         $responseData = $event->getResponseData();
         $this->assertCount(2, $responseData);
         $this->assertSame(1234, $responseData['issue']);
-        $this->assertSame(true, $responseData['removed_staled_label']);
+        $this->assertSame(true, $responseData['removed_stalled_label']);
     }
 
     public function testOnBotCommentOnStale()
     {
         $event = new GitHubEvent([
-            'issue' => ['number' => 1234, 'labels' => [['name' => 'Foo'], ['name' => 'Staled']]], 'comment' => ['user' => ['login' => 'carsonbot']],
+            'issue' => ['number' => 1234, 'labels' => [['name' => 'Foo'], ['name' => 'Stalled']]], 'comment' => ['user' => ['login' => 'carsonbot']],
         ], $this->repository);
 
         $this->dispatcher->dispatch($event, GitHubEvents::ISSUE_COMMENT);