Skip to content

Commit 97c550a

Browse files
authored
Log errors better (#111)
* Log more errors * minor * cs
1 parent a4fdc95 commit 97c550a

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

src/Service/GitHubRequestHandler.php

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44

55
use App\Event\EventDispatcher;
66
use App\Event\GitHubEvent;
7-
use Psr\Log\LoggerAwareInterface;
8-
use Psr\Log\LoggerAwareTrait;
7+
use Psr\Log\LoggerInterface;
98
use Symfony\Component\HttpFoundation\Request;
109
use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
1110
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
@@ -16,17 +15,17 @@
1615
*
1716
* @author Jules Pietri <jules@heahprod.com>
1817
*/
19-
class GitHubRequestHandler implements LoggerAwareInterface
18+
class GitHubRequestHandler
2019
{
21-
use LoggerAwareTrait;
2220
private $dispatcher;
2321
private $repositoryProvider;
24-
private $container;
22+
private $logger;
2523

26-
public function __construct(EventDispatcher $dispatcher, RepositoryProvider $repositoryProvider)
24+
public function __construct(EventDispatcher $dispatcher, RepositoryProvider $repositoryProvider, LoggerInterface $logger)
2725
{
2826
$this->dispatcher = $dispatcher;
2927
$this->repositoryProvider = $repositoryProvider;
28+
$this->logger = $logger;
3029
}
3130

3231
/**
@@ -67,7 +66,10 @@ public function handle(Request $request)
6766
try {
6867
$this->dispatcher->dispatch($event, 'github.'.$eventName);
6968
} catch (\Exception $e) {
70-
throw new \RuntimeException(sprintf('Failed dispatching "%s" event for "%s" repository.', (string) $eventName, $repository->getFullName()), 0, $e);
69+
$message = sprintf('Failed dispatching "%s" event for "%s" repository.', (string) $eventName, $repository->getFullName());
70+
$this->logger->error($message, ['exception' => $e]);
71+
72+
throw new \RuntimeException($message, 0, $e);
7173
}
7274

7375
$responseData = $event->getResponseData();

0 commit comments

Comments
 (0)