Merge pull request #48 from HeahDude/not-review-from-author

Fixed author reviewing its own PR

Author: weaverryan

src/AppBundle/Subscriber/StatusChangeByCommentSubscriber.php

@@ -50,6 +50,15 @@ public function onIssueComment(GitHubEvent $event)
             // Second subpattern = first status character
             $newStatus = static::$triggerWordToStatus[strtolower(end($matches[1]))];
 
+            if (Status::REVIEWED === $newStatus && false === $this->checkUserIsAllowedToReview($data)) {
+                $event->setResponseData(array(
+                    'issue' => $issueNumber,
+                    'status_change' => null,
+                ));
+
+                return;
+            }
+
             $this->logger->debug(sprintf('Setting issue number %s to status %s', $issueNumber, $newStatus));
             $this->statusApi->setIssueStatus($issueNumber, $newStatus, $repository);
         }
@@ -66,4 +75,9 @@ public static function getSubscribedEvents()
             GitHubEvents::ISSUE_COMMENT => 'onIssueComment',
         );
     }
+
+    private function checkUserIsAllowedToReview(array $data)
+    {
+        return $data['issue']['user']['login'] !== $data['comment']['user']['login'];
+    }
 }

src/AppBundle/Tests/Subscriber/StatusChangeByCommentSubscriberTest.php

@@ -98,4 +98,35 @@ public function getCommentsForStatusChange()
             array('Before the ticket was in state "Status: reviewed", but then the status was changed', null),
         );
     }
+
+    /**
+     * @dataProvider getCommentsForStatusChange
+     */
+    public function testOnIssueCommentAuthorSelfReview()
+    {
+        $this->statusApi->expects($this->never())
+            ->method('setIssueStatus')
+        ;
+        
+        $user = array('login' => 'weaverryan');
+
+        $event = new GitHubEvent(array(
+            'issue' => array(
+                'number' => 1234,
+                'user' => $user,
+            ),
+            'comment' => array(
+                'body' => 'Status: reviewed',
+                'user' => $user,
+            ),
+        ), $this->repository);
+
+        self::$dispatcher->dispatch(GitHubEvents::ISSUE_COMMENT, $event);
+
+        $responseData = $event->getResponseData();
+
+        $this->assertCount(2, $responseData);
+        $this->assertSame(1234, $responseData['issue']);
+        $this->assertNull($responseData['status_change']);
+    }
 }