Fix types / arrray shpes

Author: smnandre

src/Api/Issue/GithubIssueApi.php

@@ -49,9 +49,6 @@ public function lastCommentWasMadeByBot(Repository $repository, int $number): bo
         return $this->botUsername === ($lastComment['user']['login'] ?? null);
     }
 
-    /**
-     * @return array<string, mixed>
-     */
     public function show(Repository $repository, int $issueNumber): array
     {
         return $this->issueApi->show($repository->getVendor(), $repository->getName(), $issueNumber);
@@ -83,9 +80,6 @@ public function commentOnIssue(Repository $repository, int $issueNumber, string
         );
     }
 
-    /**
-     * @return array<int, array<string, mixed>>
-     */
     public function findStaleIssues(Repository $repository, \DateTimeImmutable $noUpdateAfter): iterable
     {
         return $this->resultPager->fetchAllLazy($this->searchApi, 'issues', [

src/Api/Milestone/GithubMilestoneApi.php

@@ -12,7 +12,7 @@
 class GithubMilestoneApi implements MilestoneApi
 {
     /**
-     * @var string[][]
+     * @var array<string, array<int, array{title: string, number: int}>>
      */
     private array $cache = [];
 
@@ -23,7 +23,7 @@ public function __construct(
     }
 
     /**
-     * @return array<array<string, mixed>>
+     * @return array<int, array{title: string, number: int}>
      */
     private function getMilestones(Repository $repository): array
     {

src/Command/PingStaleIssuesCommand.php

@@ -22,8 +22,8 @@
  */
 class PingStaleIssuesCommand extends Command
 {
-    public const MESSAGE_TWO_AFTER = '+2weeks';
-    public const MESSAGE_THREE_AND_CLOSE_AFTER = '+2weeks';
+    public const string MESSAGE_TWO_AFTER = '+2weeks';
+    public const string MESSAGE_THREE_AND_CLOSE_AFTER = '+2weeks';
 
     protected static $defaultName = 'app:issue:ping-stale';
 
@@ -69,6 +69,9 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         }
 
         foreach ($issues as $issue) {
+            /**
+             * @var array{number: int, name: string, labels: array<int, array{name: string}>} $issue
+             */
             $comment = $this->commentGenerator->getComment($this->extractType($issue));
             $this->issueApi->commentOnIssue($repository, $issue['number'], $comment);
             $this->labelApi->addIssueLabel($issue['number'], 'Stalled', $repository);
@@ -84,7 +87,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
      * Extract type from issue array. Make sure we prioritize labels if there are
      * more than one type defined.
      *
-     * @param array<string, mixed> $issue
+     * @param array{number: int, name: string, labels: array<int, array{name: string}>} $issue
      */
     private function extractType(array $issue): string
     {

src/Subscriber/RewriteUnwantedPhrasesSubscriber.php

@@ -60,7 +60,9 @@ public function onPullRequest(GitHubEvent $event): void
     }
 
     /**
-     * @param int &$count (optional)
+     * @param int<0, max>|null &$count
+     *
+     * @param-out int $count
      */
     private function replaceUnwantedPhrases(string $text, &$count): string
     {