bug #119 Trigger rename title when we remove a label (Nyholm)

weaverryan · weaverryan · commit 12bcbdc0b7bd · 2020-11-13T09:27:25.000-05:00
This PR was merged into the master branch. Discussion ---------- Trigger rename title when we remove a label See all actions here: https://developer.github.com/webhooks/event-payloads/#pull_request Commits ------- 99f747c Trigger rename title when we remove a label
diff --git a/src/Subscriber/AutoUpdateTitleWithLabelSubscriber.php b/src/Subscriber/AutoUpdateTitleWithLabelSubscriber.php
@@ -31,9 +31,11 @@ public function __construct(LabelApi $labelsApi, LabelNameExtractor $labelExtrac
     public function onPullRequest(GitHubEvent $event)
     {
         $data = $event->getData();
-        if ('labeled' !== $action = $data['action']) {
+        $action = $data['action'];
+        if (!in_array($action, ['labeled', 'unlabeled'])) {
             return;
         }
+
         if (!isset($data['pull_request'])) {
             // Only update PullRequests
             return;

Original file line number	Diff line number	Diff line change
`@@ -31,9 +31,11 @@ public function __construct(LabelApi $labelsApi, LabelNameExtractor $labelExtrac`
`31`	`31`	`public function onPullRequest(GitHubEvent $event)`
`32`	`32`	`{`
`33`	`33`	`$data = $event->getData();`
`34`		`- if ('labeled' !== $action = $data['action']) {`
	`34`	`+ $action = $data['action'];`
	`35`	`+ if (!in_array($action, ['labeled', 'unlabeled'])) {`
`35`	`36`	`return;`
`36`	`37`	`}`
	`38`	`+`
`37`	`39`	`if (!isset($data['pull_request'])) {`
`38`	`40`	`// Only update PullRequests`
`39`	`41`	`return;`