Skip to content

Commit 0c2ea68

Browse files
committed
They are "labels", not "tags"
1 parent 3da3003 commit 0c2ea68

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/AppBundle/Issues/IssueListener.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,10 @@ private function extractLabels($prTitle)
129129
$labels = array();
130130

131131
// e.g. "[PropertyAccess] [RFC] [WIP] Allow custom methods on property accesses"
132-
if (preg_match_all('/\[(?P<tags>.+)\]/U', $prTitle, $matches)) {
133-
foreach ($matches['tags'] as $tag) {
134-
if (in_array($tag, $this->getValidTags())) {
135-
$labels[] = $tag;
132+
if (preg_match_all('/\[(?P<labels>.+)\]/U', $prTitle, $matches)) {
133+
foreach ($matches['labels'] as $label) {
134+
if (in_array($label, $this->getValidLabels())) {
135+
$labels[] = $label;
136136
}
137137
}
138138
}
@@ -141,9 +141,9 @@ private function extractLabels($prTitle)
141141
}
142142

143143
/**
144-
* TODO: get valid tags from the repository via GitHub API
144+
* TODO: get valid labels from the repository via GitHub API
145145
*/
146-
private function getValidTags()
146+
private function getValidLabels()
147147
{
148148
return array(
149149
'Asset', 'BC Break', 'BrowserKit', 'Bug', 'Cache', 'ClassLoader',

0 commit comments

Comments
 (0)