Skip to content

Commit d1fc412

Browse files
authored
Merge pull request #273 from symfony-cmf/cleanup-typing
restricted some interfaces too much
2 parents 791b332 + 9724a91 commit d1fc412

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

src/RedirectRouteInterface.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ interface RedirectRouteInterface extends RouteObjectInterface
4545
*
4646
* If this is non-empty, the other methods won't be used.
4747
*
48-
* @return string target absolute uri
48+
* @return string|null target absolute uri
4949
*/
50-
public function getUri(): string;
50+
public function getUri(): ?string;
5151

5252
/**
5353
* Get the target route document this route redirects to.
@@ -62,7 +62,7 @@ public function getRouteTarget(): ?SymfonyRoute;
6262
* Get the name of the target route for working with the symfony standard
6363
* router.
6464
*/
65-
public function getRouteName(): string;
65+
public function getRouteName(): ?string;
6666

6767
/**
6868
* Whether this should be a permanent or temporary redirect.

src/RouteProviderInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,5 +79,5 @@ public function getRouteByName(string $name): SymfonyRoute;
7979
*
8080
* @return SymfonyRoute[] Iterable list with the keys being the names from the $names array
8181
*/
82-
public function getRoutesByNames(?array $names): array;
82+
public function getRoutesByNames(?array $names = null): iterable;
8383
}

tests/Unit/Routing/DynamicRouterTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232

3333
class DynamicRouterTest extends TestCase
3434
{
35-
3635
/**
3736
* @var UrlMatcherInterface&MockObject
3837
*/

0 commit comments

Comments
 (0)