SPC key is bound to default dired-next-line on dired-mode of emacs 31

[emacs18]

I use vim mode so that SPC should always be the global prefix key.
That is the case on emacs 30 even on dired-mode.
However, SPC is bound to dired-next-line in emacs 31 which is the default key binding for both emacs 30 and 31.
It would be very helpful if SPC behaves the same on emacs 31 as it does on emacs 30, i.e., as the global prefix key always!

Could this be fixed within spacemacs so that SPC is the global prefix key always for all versions of emacs?
Otherwise it is very disorienting to be using SPC as the prefix key always except when I'm in dired-mode on emacs 31 where I have to be using M-m instead of SPC!

[fnussbaum]

I don't have an Emacs master build handy at the moment, but I guess it could be a symptom of this issue: justbur/emacs-bind-map#12

[emacs18]

Thank you for this info. Yes it does appear to be due to bind-map issue you point out.
I tried the following patch after observing that emacs' upstream change added the extra dash in the variable name. It seems to resolve the problem I reported, i.e., SPC is now the same global prefix key in dired-mode as it is in other modes.

    diff --git a/bind-map.el b/bind-map.el
    index 41e6e5b..e52d5df 100644
    --- a/bind-map.el
    +++ b/bind-map.el
    @@ -177,7 +177,10 @@ be activated.")
         (let* ((map (intern (format "evil-%s-state-local-map" (nth 1 entry))))
                (mode (nth 0 entry))
                (global-mode (intern (format "global-%s" (nth 0 entry))))
    -           (set-explicitly (intern (format "%s-set-explicitly" mode))))
    +           ;; My temporary work-around while waiting for https://github.com/justbur/emacs-bind-map/issues/12 to be fixed.
    +           ;; See also https://github.com/emacs-mirror/emacs/commit/c05ea64d8268315093673f8be29d4ceb92198b81
    +           (dash (if (>= emacs-major-version 31) "-" ""))
    +           (set-explicitly (intern (format "%s%s-set-explicitly" mode dash))))
           (when (and (boundp global-mode) (boundp mode)
                      (boundp set-explicitly) (boundp map)
                      (keymapp (symbol-value map))

[emacs18]

I also tried applying Monnier's patch mentioned in the emacs bug report. That did not solve SPC key binding problem on dired-mode.

[bcc32]

At my site, this seems to be fixed by importing justbur/emacs-bind-map#13.

[bcc32]

That PR seems to have the effect of preventing bind-map bindings from taking effect if a major mode's initialization function errors. It's pretty disruptive since it affects the SPC leader key (making it not work in such buffers where there was a mode initialization error).

[aaronjensen]

@bcc32 is that potentially because this hook is never invoked?

(add-hook 'change-major-mode-after-body-hook
          'bind-map-change-major-mode-after-body-hook)

I'm not sure what the expected effect should be. If a major mode is failing to initialize that seems like a rather significant problem and I'm not sure that I would expect other things to work. Is there some case where major modes failing to initialize is a common and non-exceptional occurrence?

[bcc32]

It can happen if you're working on developing a major mode :)

But more commonly, I've noticed since I last reported this that it also happens when a buffer is created and displayed without explicitly calling a mode function. For example, this fairly common pattern for creating a new buffer with some output:

(with-current-buffer (get-buffer-create "*seq output*")
  (call-process "seq" nil t nil "1" "100")
  (display-buffer (current-buffer)))

results in a buffer in which bind-map's key bindings don't take effect.

[aaronjensen]

Ah, thank you for the reproduction steps.

Can you try something like this?

aaronjensen/emacs-leader-key@3fb6592

[bcc32]

Sorry, I'm a little bit confused. Is emacs-leader-key intended to be a fork of bind-map? (It's not obvious to me how to incorporate that patch into my local copy of bind-map to test it, as it doesn't apply)

[aaronjensen]

@bcc32 yea, the patch wasn't meant to apply. I meant the basic technique. I can try and add it to this PR later.