Skip to content

Wrong Parameter Names in vednn.h #1

@mergian

Description

@mergian

Hi

In https://github.com/sx-aurora-dev/vednn/blob/master/src/vednn.h#L101 the function vednnConvoltuionBackwardData has the following signature:

vednnError_t vednnConvolutionBackwardData(
    const vednnTensorParam_t 		*pParamGradIn,
    const void 				*pDataGradIn,
    const vednnFilterParam_t		*pParamKernel,
    const void 				*pDataKernel,
    const vednnTensorParam_t 		*pParamGradOut,
    void 				*pDataGradOut,
    const vednnConvolutionParam_t	*pParamConv,
    vednnConvolutionAlgorithm_t 	algo
) ;

In https://github.com/sx-aurora-dev/vednn/blob/master/src/C/vednnConvolutionBackwardData.c#L64 the signature is:

vednnError_t vednnConvolutionBackwardData(
    const vednnTensorParam_t 		*pParamGradOut,
    const void 				*pDataGradOut,
    const vednnFilterParam_t		*pParamKernel,
    const void 				*pDataKernel,
    const vednnTensorParam_t 		*pParamGradIn,
    void 				*pDataGradIn,
    const vednnConvolutionParam_t	*pParamConv,
    vednnConvolutionAlgorithm_t 	algo
)

So pParamGradOut and pParamGradIn are swapped.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions