[DebugInfo][NFC] Do not call 'isRootFile' for DWARF Version < 5

igorkudrin · igorkudrin · commit 86b08ed6bb16 · 2022-01-21T13:52:10.000+07:00
A quicker comparison should be done first. Differential Revision: https://reviews.llvm.org/D117786
diff --git a/llvm/lib/MC/MCDwarf.cpp b/llvm/lib/MC/MCDwarf.cpp
@@ -586,7 +586,7 @@ MCDwarfLineTableHeader::tryGetFile(StringRef &Directory,
     trackMD5Usage(Checksum.hasValue());
     HasSource = (Source != None);
   }
-  if (isRootFile(RootFile, Directory, FileName, Checksum) && DwarfVersion >= 5)
+  if (DwarfVersion >= 5 && isRootFile(RootFile, Directory, FileName, Checksum))
     return 0;
   if (FileNumber == 0) {
     // File numbers start with 1 and/or after any file numbers

Original file line number	Diff line number	Diff line change
`@@ -586,7 +586,7 @@ MCDwarfLineTableHeader::tryGetFile(StringRef &Directory,`
`586`	`586`	`trackMD5Usage(Checksum.hasValue());`
`587`	`587`	`HasSource = (Source != None);`
`588`	`588`	`}`
`589`		`- if (isRootFile(RootFile, Directory, FileName, Checksum) && DwarfVersion >= 5)`
	`589`	`+ if (DwarfVersion >= 5 && isRootFile(RootFile, Directory, FileName, Checksum))`
`590`	`590`	`return 0;`
`591`	`591`	`if (FileNumber == 0) {`
`592`	`592`	`// File numbers start with 1 and/or after any file numbers`