JavaKit: add source/target versions to Java2Swift.config #166
Conversation
lhoward
force-pushed
the
lhoward/javac-version-args
branch
from
902fc47 to
8825d11
Compare
| /// Configuration for the Java2Swift translation tool, provided on a per-target | ||
| /// basis. | ||
| /// | ||
| /// Note: there is a copy of this struct in the Java2Swift library. They |
There was a problem hiding this comment.
Since we are forced into this because plugins can’t have dependencies, I wonder if we need to set up a ci task to check those are indeed the same… we can do that 🤔
But maybe later on, as the project becomes more stable.
There was a problem hiding this comment.
Yeah, or maybe a makefile target to copy them from a SSOT.
There was a problem hiding this comment.
I’d love to not have to use make in this build but I guess for such stuff maybe we will still… just because we already have swift gradle AND make so it’d be nice to just have two builds to worry about…
but i think it’d be okey to use make just for some simple automation but let actual “building” to swiftpm and gradle. So your idea here may be good :)
There was a problem hiding this comment.
Either way, right now the copy is fine
|
Sorry for the delay, I'll get CI green tomorrow and merge all such pending PRs. Since we use nightly toolchain it regressed us accidentally |
| let configFile = URL(filePath: sourceDir) | ||
| .appending(path: "Java2Swift.config") | ||
| let configData = try Data(contentsOf: configFile) | ||
| let config = try JSONDecoder().decode(Configuration.self, from: configData) |
There was a problem hiding this comment.
Hmm, we probably want to make the config file optional for JavaCompiler. Let me fix this.
lhoward
force-pushed
the
lhoward/javac-version-args
branch
from
8825d11 to
0233236
Compare
Fixes: #152