Skip to content

Java2Swift: Don't omit "extends" clause when it's extending JavaObject #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Sources/Java2SwiftLib/JavaClassTranslator.swift
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,7 @@ struct JavaClassTranslator {
self.nestedClasses = translator.nestedClasses[fullName] ?? []

// Superclass.
if !javaClass.isInterface(),
let javaSuperclass = javaClass.getSuperclass(),
javaSuperclass.getName() != "java.lang.Object"
{
if !javaClass.isInterface(), let javaSuperclass = javaClass.getSuperclass() {
do {
self.swiftSuperclass = try translator.getSwiftTypeName(javaSuperclass).swiftName
} catch {
Expand Down
2 changes: 1 addition & 1 deletion Sources/JavaKit/generated/JavaBoolean.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Auto-generated by Java-to-Swift wrapper generator.
import JavaRuntime

@JavaClass("java.lang.Boolean")
@JavaClass("java.lang.Boolean", extends: JavaObject.self)
public struct JavaBoolean {
@JavaMethod
public init(_ arg0: Bool, environment: JNIEnvironment? = nil)
Expand Down
4 changes: 2 additions & 2 deletions Sources/JavaKit/generated/JavaCharacter.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Auto-generated by Java-to-Swift wrapper generator.
import JavaRuntime

@JavaClass("java.lang.Character")
@JavaClass("java.lang.Character", extends: JavaObject.self)
public struct JavaCharacter {
@JavaMethod
public init(_ arg0: UInt16, environment: JNIEnvironment? = nil)
Expand Down Expand Up @@ -3147,7 +3147,7 @@ extension JavaClass<JavaCharacter.UnicodeScript> {
public func of(_ arg0: Int32) -> JavaCharacter.UnicodeScript!
}
extension JavaCharacter {
@JavaClass("java.lang.Character$Subset")
@JavaClass("java.lang.Character$Subset", extends: JavaObject.self)
public struct Subset {
@JavaMethod
public func equals(_ arg0: JavaObject?) -> Bool
Expand Down
2 changes: 1 addition & 1 deletion Sources/JavaKit/generated/JavaClass.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Auto-generated by Java-to-Swift wrapper generator.
import JavaRuntime

@JavaClass("java.lang.Class")
@JavaClass("java.lang.Class", extends: JavaObject.self)
public struct JavaClass<T: AnyJavaObject> {
@JavaMethod
public func getName() -> String
Expand Down
2 changes: 1 addition & 1 deletion Sources/JavaKit/generated/JavaNumber.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Auto-generated by Java-to-Swift wrapper generator.
import JavaRuntime

@JavaClass("java.lang.Number")
@JavaClass("java.lang.Number", extends: JavaObject.self)
public struct JavaNumber {
@JavaMethod
public init(environment: JNIEnvironment? = nil)
Expand Down
2 changes: 1 addition & 1 deletion Sources/JavaKit/generated/JavaVoid.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Auto-generated by Java-to-Swift wrapper generator.
import JavaRuntime

@JavaClass("java.lang.Void")
@JavaClass("java.lang.Void", extends: JavaObject.self)
public struct JavaVoid {
@JavaMethod
public func equals(_ arg0: JavaObject?) -> Bool
Expand Down
2 changes: 1 addition & 1 deletion Sources/JavaKit/generated/Throwable.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Auto-generated by Java-to-Swift wrapper generator.
import JavaRuntime

@JavaClass("java.lang.Throwable")
@JavaClass("java.lang.Throwable", extends: JavaObject.self)
public struct Throwable {
@JavaMethod
public init(_ arg0: Throwable?, environment: JNIEnvironment? = nil)
Expand Down
2 changes: 1 addition & 1 deletion Sources/JavaKitCollection/generated/BitSet.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import JavaKit
import JavaRuntime

@JavaClass("java.util.BitSet")
@JavaClass("java.util.BitSet", extends: JavaObject.self)
public struct BitSet {
@JavaMethod
public init(environment: JNIEnvironment? = nil)
Expand Down
86 changes: 86 additions & 0 deletions Sources/JavaKitCollection/generated/HashMap.swift
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,92 @@ public struct HashMap<K: AnyJavaObject, V: AnyJavaObject> {
@JavaMethod
public func wait() throws
}
extension HashMap {
@JavaClass("java.util.AbstractMap$SimpleImmutableEntry", extends: JavaObject.self)
public struct SimpleImmutableEntry<K: AnyJavaObject, V: AnyJavaObject> {
@JavaMethod
public init(_ arg0: JavaObject?, _ arg1: JavaObject?, environment: JNIEnvironment? = nil)

@JavaMethod
public func equals(_ arg0: JavaObject?) -> Bool

@JavaMethod
public func toString() -> String

@JavaMethod
public func hashCode() -> Int32

@JavaMethod
public func getValue() -> JavaObject!

@JavaMethod
public func getKey() -> JavaObject!

@JavaMethod
public func setValue(_ arg0: JavaObject?) -> JavaObject!

@JavaMethod
public func getClass() -> JavaClass<JavaObject>!

@JavaMethod
public func notify()

@JavaMethod
public func notifyAll()

@JavaMethod
public func wait(_ arg0: Int64) throws

@JavaMethod
public func wait(_ arg0: Int64, _ arg1: Int32) throws

@JavaMethod
public func wait() throws
}
}
extension HashMap {
@JavaClass("java.util.AbstractMap$SimpleEntry", extends: JavaObject.self)
public struct SimpleEntry<K: AnyJavaObject, V: AnyJavaObject> {
@JavaMethod
public init(_ arg0: JavaObject?, _ arg1: JavaObject?, environment: JNIEnvironment? = nil)

@JavaMethod
public func equals(_ arg0: JavaObject?) -> Bool

@JavaMethod
public func toString() -> String

@JavaMethod
public func hashCode() -> Int32

@JavaMethod
public func getValue() -> JavaObject!

@JavaMethod
public func getKey() -> JavaObject!

@JavaMethod
public func setValue(_ arg0: JavaObject?) -> JavaObject!

@JavaMethod
public func getClass() -> JavaClass<JavaObject>!

@JavaMethod
public func notify()

@JavaMethod
public func notifyAll()

@JavaMethod
public func wait(_ arg0: Int64) throws

@JavaMethod
public func wait(_ arg0: Int64, _ arg1: Int32) throws

@JavaMethod
public func wait() throws
}
}
extension JavaClass {
@JavaStaticMethod
public func newHashMap<K: AnyJavaObject, V: AnyJavaObject>(_ arg0: Int32) -> HashMap<JavaObject, JavaObject>! where ObjectType == HashMap<K, V>
Expand Down
2 changes: 1 addition & 1 deletion Sources/JavaKitCollection/generated/JavaDictionary.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import JavaKit
import JavaRuntime

@JavaClass("java.util.Dictionary")
@JavaClass("java.util.Dictionary", extends: JavaObject.self)
public struct JavaDictionary<K: AnyJavaObject, V: AnyJavaObject> {
@JavaMethod
public init(environment: JNIEnvironment? = nil)
Expand Down
86 changes: 0 additions & 86 deletions Sources/JavaKitCollection/generated/TreeMap.swift
Original file line number Diff line number Diff line change
Expand Up @@ -106,89 +106,3 @@ public struct TreeMap<K: AnyJavaObject, V: AnyJavaObject> {
@JavaMethod
public func getOrDefault(_ arg0: JavaObject?, _ arg1: JavaObject?) -> JavaObject!
}
extension TreeMap {
@JavaClass("java.util.AbstractMap$SimpleImmutableEntry")
public struct SimpleImmutableEntry<K: AnyJavaObject, V: AnyJavaObject> {
@JavaMethod
public init(_ arg0: JavaObject?, _ arg1: JavaObject?, environment: JNIEnvironment? = nil)

@JavaMethod
public func equals(_ arg0: JavaObject?) -> Bool

@JavaMethod
public func toString() -> String

@JavaMethod
public func hashCode() -> Int32

@JavaMethod
public func getValue() -> JavaObject!

@JavaMethod
public func getKey() -> JavaObject!

@JavaMethod
public func setValue(_ arg0: JavaObject?) -> JavaObject!

@JavaMethod
public func getClass() -> JavaClass<JavaObject>!

@JavaMethod
public func notify()

@JavaMethod
public func notifyAll()

@JavaMethod
public func wait(_ arg0: Int64) throws

@JavaMethod
public func wait(_ arg0: Int64, _ arg1: Int32) throws

@JavaMethod
public func wait() throws
}
}
extension TreeMap {
@JavaClass("java.util.AbstractMap$SimpleEntry")
public struct SimpleEntry<K: AnyJavaObject, V: AnyJavaObject> {
@JavaMethod
public init(_ arg0: JavaObject?, _ arg1: JavaObject?, environment: JNIEnvironment? = nil)

@JavaMethod
public func equals(_ arg0: JavaObject?) -> Bool

@JavaMethod
public func toString() -> String

@JavaMethod
public func hashCode() -> Int32

@JavaMethod
public func getValue() -> JavaObject!

@JavaMethod
public func getKey() -> JavaObject!

@JavaMethod
public func setValue(_ arg0: JavaObject?) -> JavaObject!

@JavaMethod
public func getClass() -> JavaClass<JavaObject>!

@JavaMethod
public func notify()

@JavaMethod
public func notifyAll()

@JavaMethod
public func wait(_ arg0: Int64) throws

@JavaMethod
public func wait(_ arg0: Int64, _ arg1: Int32) throws

@JavaMethod
public func wait() throws
}
}
4 changes: 2 additions & 2 deletions Sources/JavaKitJar/generated/Attributes.swift
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import JavaKit
import JavaKitCollection
import JavaRuntime

@JavaClass("java.util.jar.Attributes")
@JavaClass("java.util.jar.Attributes", extends: JavaObject.self)
public struct Attributes {
@JavaMethod
public init(_ arg0: Attributes?, environment: JNIEnvironment? = nil)
Expand Down Expand Up @@ -99,7 +99,7 @@ public struct Attributes {
public func getOrDefault(_ arg0: JavaObject?, _ arg1: JavaObject?) -> JavaObject!
}
extension Attributes {
@JavaClass("java.util.jar.Attributes$Name")
@JavaClass("java.util.jar.Attributes$Name", extends: JavaObject.self)
public struct Name {
@JavaMethod
public init(_ arg0: String, environment: JNIEnvironment? = nil)
Expand Down
2 changes: 1 addition & 1 deletion Sources/JavaKitJar/generated/Manifest.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import JavaKit
import JavaRuntime

@JavaClass("java.util.jar.Manifest")
@JavaClass("java.util.jar.Manifest", extends: JavaObject.self)
public struct Manifest {
@JavaMethod
public init(_ arg0: Manifest?, environment: JNIEnvironment? = nil)
Expand Down
2 changes: 1 addition & 1 deletion Sources/JavaKitNetwork/generated/URI.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import JavaKit
import JavaRuntime

@JavaClass("java.net.URI")
@JavaClass("java.net.URI", extends: JavaObject.self)
public struct URI {
@JavaMethod
public init(_ arg0: String, _ arg1: String, _ arg2: String, _ arg3: String, _ arg4: String, environment: JNIEnvironment? = nil) throws
Expand Down
2 changes: 1 addition & 1 deletion Sources/JavaKitNetwork/generated/URL.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import JavaKit
import JavaRuntime

@JavaClass("java.net.URL")
@JavaClass("java.net.URL", extends: JavaObject.self)
public struct URL {
@JavaMethod
public init(_ arg0: URL?, _ arg1: String, environment: JNIEnvironment? = nil) throws
Expand Down
2 changes: 1 addition & 1 deletion Sources/JavaKitReflection/generated/AccessibleObject.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import JavaKit
import JavaRuntime

@JavaClass("java.lang.reflect.AccessibleObject")
@JavaClass("java.lang.reflect.AccessibleObject", extends: JavaObject.self)
public struct AccessibleObject {
@JavaMethod
public func isAnnotationPresent(_ arg0: JavaClass<Annotation>?) -> Bool
Expand Down
2 changes: 1 addition & 1 deletion Sources/JavaKitReflection/generated/Parameter.swift
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import JavaKit
import JavaKitCollection
import JavaRuntime

@JavaClass("java.lang.reflect.Parameter")
@JavaClass("java.lang.reflect.Parameter", extends: JavaObject.self)
public struct Parameter {
@JavaMethod
public func getName() -> String
Expand Down
2 changes: 1 addition & 1 deletion Tests/Java2SwiftTests/Java2SwiftTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class Java2SwiftTests: XCTestCase {
expectedChunks: [
"import JavaKit",
"""
@JavaClass("java.lang.Class")
@JavaClass("java.lang.Class", extends: JavaObject.self)
public struct MyJavaClass<T: AnyJavaObject> {
""",
"""
Expand Down