Skip to content

Commit b55cd4d

Browse files
committed
Java2Swift: fullJavaClassName needs to be "open class" in class-generation mode
1 parent 1715af8 commit b55cd4d

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

Sources/JavaKitMacros/JavaClassMacro.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,10 @@ extension JavaClassMacro: MemberMacro {
9191
fullJavaClassNameMemberModifiers = "class"
9292
}
9393

94+
let classNameAccessSpecifier = isSwiftClass ? "open" : "public"
9495
members.append("""
9596
/// The full Java class name for this Swift type.
96-
public \(raw: fullJavaClassNameMemberModifiers) var fullJavaClassName: String { \(literal: className) }
97+
\(raw: classNameAccessSpecifier) \(raw: fullJavaClassNameMemberModifiers) var fullJavaClassName: String { \(literal: className) }
9798
"""
9899
)
99100

Tests/JavaKitMacroTests/JavaClassMacroTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ class JavaKitMacroTests: XCTestCase {
186186
}
187187
188188
/// The full Java class name for this Swift type.
189-
public override class var fullJavaClassName: String {
189+
open override class var fullJavaClassName: String {
190190
"org.swift.example.HelloWorld"
191191
}
192192
@@ -227,7 +227,7 @@ class JavaKitMacroTests: XCTestCase {
227227
}
228228
229229
/// The full Java class name for this Swift type.
230-
public class var fullJavaClassName: String {
230+
open class var fullJavaClassName: String {
231231
"java.lang.Object"
232232
}
233233

0 commit comments

Comments
 (0)