Address code review comments

DougGregor · DougGregor · commit 8496f1a4cae0 · 2024-10-14T21:18:06.000-07:00
diff --git a/.licenseignore b/.licenseignore
@@ -5,6 +5,7 @@
 .swift-format
 .github/*
 *.md
+**/*.config
 CONTRIBUTORS.txt
 LICENSE.txt
 NOTICE.txt
diff --git a/Package.swift b/Package.swift
@@ -58,7 +58,7 @@ let package = Package(
 
     .library(
       name: "JavaRuntime",
-      targets: [ "JavaRuntime"]
+      targets: ["JavaRuntime"]
     ),
 
     .library(
diff --git a/Samples/JavaKitSampleApp/Sources/JavaKitExample/Java2Swift.config b/Samples/JavaKitSampleApp/Sources/JavaKitExample/Java2Swift.config
@@ -1,5 +1,5 @@
 {
   "classes" : {
-    "java.util.Vector" : null
+    "java.util.ArrayList" : "ArrayList"
   }
 }
diff --git a/Samples/JavaKitSampleApp/Sources/JavaKitExample/JavaKitExample.swift b/Samples/JavaKitSampleApp/Sources/JavaKitExample/JavaKitExample.swift
@@ -119,6 +119,6 @@ struct HelloSubclass {
 }
 
 
-func returnNilVector() -> Vector<JavaClass<HelloSwift>>? {
+func returnNilVector() -> ArrayList<JavaClass<HelloSwift>>? {
   nil
 }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"classes" : {`
`3`		`- "java.util.Vector" : null`
	`3`	`+ "java.util.ArrayList" : "ArrayList"`
`4`	`4`	`}`
`5`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -119,6 +119,6 @@ struct HelloSubclass {`
`119`	`119`	`}`
`120`	`120`
`121`	`121`
`122`		`-func returnNilVector() -> Vector<JavaClass<HelloSwift>>? {`
	`122`	`+func returnNilVector() -> ArrayList<JavaClass<HelloSwift>>? {`
`123`	`123`	`nil`
`124`	`124`	`}`