Is #[ast_serde] still useful?

[hyf0]

I'm trying to be familiar with the codebase. Is this comment still meaningful?

swc/crates/ast_node/src/lib.rs

Line 161 in 2017daa

/// TODO: Delete works related to serde to `#[ast_serde]`.

[kdy1]

Oh it's not delete but it should be delegate

[kdy1]

No, it means #[ast_node] will call #[ast_serde] by generating attrs

[hyf0]

Is this a good first issue? If it is, I will give it a try.

[kdy1]

I don't think so as it will make compile time longer.
Calling it directly from proc macro is better

[hyf0]

Well, I guess I could delete this comment at least? :)

[kdy1]

Yrah I think so, thanks!