Throwing SyntaxError instead of Error

[idan-at]

Hey,

when using @swc/core and one of the transform* methods, In case of a syntax error, it throws a very detailed error, but of type Error with a GenericFailure code.

I think it is more appropriate to throw the standard SyntaxError (which babel also throws on these cases).

WDYT? Is there a particular reason swc does not use SyntaxError ?

Thanks!

[kdy1]

Seems like a good change to me.
There's no special reason to use Error.

[idan-at]

@kdy1 thanks for your previous response.

The relevant functions didn't exist on N-API. I've added those to node and also to napi-rs, under the experimental flag.

I see swc still uses v1. Are you planning to upgrade soon?
Also, from my understanding, napi-rs needs to expose an experimental feature flag here, so swc can declare using it?

[idan-at]

@kdy1 I've contributed to napi-rs and I see swc was recently updated to use napi-rs v2.

Can you please LMK if it's fine to add the experimental flag and use the new APIs?

Thanks.

[kdy1]

I think a flag is not required.
All SyntaxErorr is Error and the only way a user can match it is looking at the error message.

[idan-at]

I mean adding the feature flag here

Also, I see that the APIs were only added in node 17.2.0. Can we somehow add a flag to check which version swc is running with and perform this change only if the functions exists?

Sorry for the noob questions, I'm new to the Rust environment.

[kdy1]

Oh.

Also, I see that the APIs were only added in node 17.2.0. Can we somehow add a flag to check which version swc is running with and perform this change only if the functions exists?

This seems like a serious issue.
I'm not sure if napi-rs supports such behavior