remove the need_tap argument since it is not used

Author: arnaud-ma

src/tap/tap.py

@@ -483,9 +483,7 @@ def parse_args(
         return self
 
     @classmethod
-    def _get_from_self_and_super(
-        cls, extract_func: Callable[[type], dict], *, need_tap_cls: bool = True,
-    ) -> Union[Dict[str, Any], Dict]:
+    def _get_from_self_and_super( cls, extract_func: Callable[[type], dict]) -> Union[Dict[str, Any], Dict]:
         """Returns a dictionary mapping variable names to values.
 
         Variables and values are extracted from classes using key starting
@@ -496,7 +494,6 @@ def _get_from_self_and_super(
         Super classes are traversed through breadth first search.
 
         :param extract_func: A function that extracts from a class a dictionary mapping variables to values.
-        :param need_tap_cls: If False, variables from the Tap and ArgumentParser classes are ignored.
         :return: A dictionary mapping variable names to values from the class dict.
         """
         visited = set()
@@ -506,10 +503,7 @@ def _get_from_self_and_super(
         while len(super_classes) > 0:
             super_class = super_classes.pop(0)
 
-            if not need_tap_cls and super_class is Tap:
-                break
-
-            if super_class not in visited and issubclass(super_class, Tap):
+            if super_class not in visited and issubclass(super_class, Tap) and super_class is not Tap:
                 super_dictionary = extract_func(super_class)
 
                 # Update only unseen variables to avoid overriding subclass values
@@ -527,8 +521,7 @@ def _get_from_self_and_super(
     def _get_class_dict(self) -> Dict[str, Any]:
         """Returns a dictionary mapping class variable names to values from the class dict."""
         class_dict = self._get_from_self_and_super(
-            extract_func=lambda super_class: dict(getattr(super_class, "__dict__", dict())),
-            need_tap_cls=False,
+            extract_func=lambda super_class: dict(getattr(super_class, "__dict__", dict()))
         )
         class_dict = {
             var: val
@@ -545,18 +538,15 @@ def _get_class_dict(self) -> Dict[str, Any]:
     def _get_annotations(self) -> Dict[str, Any]:
         """Returns a dictionary mapping variable names to their type annotations."""
         return self._get_from_self_and_super(
-            extract_func=lambda super_class: dict(get_type_hints(super_class)),
-            need_tap_cls=False,
+            extract_func=lambda super_class: dict(get_type_hints(super_class))
         )
 
     def _get_class_variables(self) -> dict:
         """Returns a dictionary mapping class variables names to their additional information."""
         class_variable_names = {**self._get_annotations(), **self._get_class_dict()}.keys()
 
         try:
-            class_variables = self._get_from_self_and_super(
-                extract_func=get_class_variables, need_tap_cls=False,
-            )
+            class_variables = self._get_from_self_and_super(extract_func=get_class_variables)
 
             # Handle edge-case of source code modification while code is running
             variables_to_add = class_variable_names - class_variables.keys()
@@ -597,7 +587,6 @@ def as_dict(self) -> Dict[str, Any]:
         self_dict = self.__dict__
         class_dict = self._get_from_self_and_super(
             extract_func=lambda super_class: dict(getattr(super_class, "__dict__", dict())),
-            need_tap_cls=False,
         )
         class_dict = {key: val for key, val in class_dict.items() if key not in self_dict}
         stored_dict = {**self_dict, **class_dict}