Fail on invalid remote JSON schema (#96)

Author: lku

src/RefResolver.php

@@ -194,8 +194,8 @@ public function resolveReference($referencePath)
                     $this->setResolutionScope($url);
                     if (null === $refResolver) {
                         $rootData = $rootResolver->getRefProvider()->getSchemaData($url);
-                        if ($rootData === false) {
-                            throw new Exception("Failed to resolve $url", Exception::RESOLVE_FAILED);
+                        if ($rootData === null || $rootData === false) {
+                            throw new Exception("Failed to decode content from $url", Exception::RESOLVE_FAILED);
                         }
 
                         $refResolver = new RefResolver($rootData);

tests/resources/invalid_json.json

@@ -0,0 +1,3 @@
+{
+    "$schema": "http://json-schema.org/draft-07/schema#",
+}

tests/src/PHPUnit/Schema/InvalidSchemaTest.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace Swaggest\JsonSchema\Tests\PHPUnit\Schema;
+
+use Swaggest\JsonSchema\Schema;
+
+class InvalidSchemaTest extends \PHPUnit_Framework_TestCase
+{
+
+    public function testValidationFailedWithInvalidSchema()
+    {
+        $this->setExpectedException('Swaggest\JsonSchema\Exception');
+        $data = __DIR__ . '/../../../resources/invalid_json.json';
+        $schema = Schema::import($data);
+        $schema->in(json_decode(<<<'JSON'
+{
+    "id": 1,
+    "name":"John Doe",
+    "orders":[
+        {
+            "id":1
+        },
+        {
+            "price":1.0
+        }
+    ]
+}
+JSON
+        ));
+    }
+
+}