Improve ps1 detection script to correctly parse winget output

[mdurini-swisscom]

I tried to deploy Anydesk 9.0.4 published with this command
new-wtWingetPackage -PackageId AnyDesk.AnyDesk -PreferedInstaller exe -PackageFolder "XXXXX\WingetPackages\" | Deploy-WtWin32App
and I got the install failure notification but the application was installed. I checked the output of the script and I saw that Anydesk version was "ad", causing the exception of the script

I found a different way to parse the winget output (thanks to alkampfergit script)

$packageId = "AnyDesk.AnyDesk"
$version = "9.0.4"

Start-Transcript -Path "$env:ProgramData\Microsoft\IntuneManagementExtension\Logs\$packageId-detection.log" -Force
Write-Host "Starting $packageId detection"

# Need to get the full path of winget, because detection script is run in a different context
Function Get-WingetCmd {

    $WingetCmd = $null
    #Get WinGet Path

    try {
        # Get Admin Context Winget Location
        $WingetInfo = (Get-Item "$env:ProgramFiles\WindowsApps\Microsoft.DesktopAppInstaller_*_8wekyb3d8bbwe\winget.exe").VersionInfo | Sort-Object -Property FileVersionRaw
        # if multiple versions, pick most recent one
        $WingetCmd = $WingetInfo[-1].FileName
    }
    catch {
        #Get User context Winget Location
        if (Test-Path "$env:LocalAppData\Microsoft\WindowsApps\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\winget.exe")
        {
            $WingetCmd ="$env:LocalAppData\Microsoft\WindowsApps\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\winget.exe"
        }
    }
    Write-Host "Winget location: $WingetCmd"
    return $WingetCmd
}
 
$wingetCmd = Get-WingetCmd
if ($null -eq $wingetCmd) {
    Write-Host "winget not detected"
    Exit 1
}
[Console]::OutputEncoding = [System.Text.Encoding]::UTF8
$wingetOutput = & $wingetCmd "list" "--id" $packageId "--exact" "--disable-interactivity" "--accept-source-agreements"

if($wingetOutput -is [array]) {
    $lastRow = $wingetOutput[$wingetOutput.Length -1]
    if ($lastRow.Contains("$packageId $version")) {
        Write-Host "$($packageId) version $($version) is installed"
        Exit 0
    } elseif ($lastRow.Contains($packageId)) {
        $wingetOutputAsString = $wingetOutput | Out-String
        $lines = $wingetOutputAsString.Split([Environment]::NewLine)
        # Find the line that starts with Name, it contains the header
        $fl = 0
        while (-not $lines[$fl].StartsWith("Name"))
        {
            $fl++
        }
        # Line $i has the header, we can find char where we find ID and Version
        $versionStart = $lines[$fl].IndexOf("Version")
        $sourceStart = $lines[$fl].IndexOf("Source")
 
        $installedVersion = ($lastRow.Substring($versionStart, $sourceStart - $versionStart).TrimEnd()) -replace '[a-zA-Z]',''
        [reflection.assembly]::LoadWithPartialName("System.Version")
        $versionExpected = New-Object System.Version($version)
        $versionInstalled = New-Object System.Version($installedVersion)
        Write-Host "$($packageId) version $($installedVersion) is installed"
        $result = $versionExpected.CompareTo($versionInstalled);
        if (1 -eq $result) {
            Write-Host "Installed version is lower"
            Exit 5
        }
        Exit 0
    }
}

Write-Host "$($packageId) not detected using winget"
Exit 10

[svrooij]

Can you explain what has changed with this new version? What where you trying to solve?

[svrooij]

Let's conclude that ad is not supposed to be in the version number.....

Can you run winget list --id AnyDesk.AnyDesk --exact
And share the output as text with us?

A large text area in GitHub can be created by using three tics above and below. https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#quoting-code

[mdurini-swisscom]

totally agree with you :-)

winget list --id AnyDesk.AnyDesk --exact
Name    Id              Version  Source
----------------------------------------
AnyDesk AnyDesk.AnyDesk ad 9.0.4 winget

[svrooij]

Maybe it is better to use some regular expression magic to get a version number from the first line. As in space{number}.{number}.{number}space

I'm currently working on the detection script and making it easier for others to contribute stuff like that, by embedding a script. This means after my update there is a .PS1 file in the source, that gets transformed in the actual detection script. So no longer needed to modify the C# code

[mdurini-swisscom]

got it. up to you, the script that i posted initially already handle the parsing in a good way, i tested it with several applications and it works ;-)

[svrooij]

This is definitly a winget issue, so I created microsoft/winget-cli#5292

Apart from that I decided to go for:

if ($lastRow.Contains("$packageId $version") or $lastRow.Contains($packageId) and $lastRow.Contains($version)) {
    Write-Host "$($packageId) version $($version) is installed"
    Write-Host "Exiting with code 0"
    Exit 0
}

which should just ignore the stupid version issue.