Skip to content

Commit dd67a74

Browse files
committed
chore: configuration cache changes for Jib task
1 parent e2f0dfc commit dd67a74

File tree

5 files changed

+24
-19
lines changed

5 files changed

+24
-19
lines changed

gradle/build-logic/src/main/kotlin/common/ProjectExtns.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,9 @@ val Project.containerLabels
203203
val Project.defaultJvmArgs
204204
get() = buildList {
205205
addAll(libs.versions.java.jvmargs.get().split(",", " ").filter(String::isNotBlank))
206-
add("--add-modules=$addModules")
206+
if (addModules.isNotBlank()) {
207+
add("--add-modules=$addModules")
208+
}
207209
}
208210

209211
/**
@@ -297,7 +299,6 @@ val Project.runJvmArgs
297299
"-Dcom.sun.management.jmxremote.authenticate=false",
298300
"-Dcom.sun.management.jmxremote.ssl=false",
299301
"-Djava.rmi.server.hostname=0.0.0.0",
300-
"-Dio.ktor.development=${project.hasProperty("development")}",
301302
// "--sun-misc-unsafe-memory-access=warn",
302303
// "--finalization=enabled",
303304
// "-XX:OnOutOfMemoryError='kill -9 %p'",

gradle/build-logic/src/main/kotlin/dev.suresh.plugin.kotlin.jvm.gradle.kts

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
2-
import com.google.devtools.ksp.gradle.KspAATask
2+
import com.google.cloud.tools.jib.gradle.JibTask
33
import common.*
44
import java.io.*
55
import java.util.spi.ToolProvider
@@ -95,9 +95,6 @@ tasks {
9595
// Configure jvm args for JavaExec tasks except `run`
9696
withType<JavaExec>().matching { it.name != "run" }.configureEach { jvmArgs(defaultJvmArgs) }
9797

98-
// Configure KSP
99-
withType<KspAATask>().configureEach { configureKspConfig() }
100-
10198
withType<Jar>().configureEach {
10299
manifest { attributes(defaultJarManifest) }
103100
duplicatesStrategy = DuplicatesStrategy.INCLUDE
@@ -129,11 +126,13 @@ tasks {
129126
encoding = Charsets.UTF_8.name()
130127
linkSource(true)
131128
addBooleanOption("-enable-preview", true)
132-
addStringOption("-add-modules", addModules)
129+
if (addModules.isNotBlank()) {
130+
addStringOption("-add-modules", addModules)
131+
}
133132
addStringOption("-release", javaRelease.get().toString())
134133
addStringOption("Xdoclint:none", "-quiet")
135134
}
136-
exclude("**/Main.java")
135+
// exclude("**/Main.java")
137136
}
138137

139138
pluginManager.withPlugin("com.gradleup.shadow") {
@@ -204,6 +203,12 @@ tasks {
204203
}
205204

206205
processResources { dependsOn(copyOtelAgent) }
206+
207+
// Disable configuration cache for Jib
208+
withType<JibTask>().configureEach {
209+
notCompatibleWithConfigurationCache(
210+
"because https://github.com/GoogleContainerTools/jib/issues/3132")
211+
}
207212
}
208213

209214
pluginManager.withPlugin("org.jetbrains.kotlinx.binary-compatibility-validator") {

gradle/build-logic/src/main/kotlin/dev.suresh.plugin.kotlin.mpp.gradle.kts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
@file:Suppress("UnstableApiUsage")
22

33
import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
4-
import com.google.devtools.ksp.gradle.KspAATask
4+
import com.google.cloud.tools.jib.gradle.JibTask
55
import common.*
66
import kotlinx.validation.*
77
import org.gradle.internal.os.OperatingSystem
@@ -98,8 +98,6 @@ tasks {
9898
kotlin.sourceSets.commonMain { kotlin.srcDirs(buildConfig) }
9999
// compileKotlinMetadata { dependsOn(buildConfig) }
100100

101-
withType<KspAATask>().configureEach { configureKspConfig() }
102-
103101
withType<KotlinNpmInstallTask>().configureEach { configureKotlinNpm() }
104102

105103
// withType<Kotlin2JsCompile>().configureEach {}
@@ -155,6 +153,14 @@ tasks {
155153
}
156154
}
157155

156+
pluginManager.withPlugin("com.google.cloud.tools.jib") {
157+
// Disable configuration cache for Jib
158+
withType<JibTask>().configureEach {
159+
notCompatibleWithConfigurationCache(
160+
"because https://github.com/GoogleContainerTools/jib/issues/3132")
161+
}
162+
}
163+
158164
pluginManager.withPlugin("org.jetbrains.kotlinx.binary-compatibility-validator") {
159165
configure<ApiValidationExtension> {
160166
ignoredPackages.add("dev.suresh.test")

gradle/build-logic/src/main/kotlin/dev.suresh.plugin.publishing.gradle.kts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -114,13 +114,6 @@ signing {
114114
}
115115
}
116116

117-
nmcp {
118-
centralPortal {
119-
username = mavenCentralUsername
120-
password = mavenCentralPassword
121-
}
122-
}
123-
124117
fun MavenPublication.configurePom() {
125118
pom {
126119
name = provider { "${project.group}:${project.name}" }

gradle/build-logic/src/main/kotlin/dev.suresh.plugin.repos.settings.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import org.gradle.toolchains.foojay.FoojayToolchainResolver
1010
import org.tomlj.Toml
1111

1212
val versionCatalog by lazy {
13-
// A hack to read version catalog from settings
13+
// A hack to read the version catalog from settings
1414
runCatching {
1515
Toml.parse(settingsDir.resolve("gradle/libs.versions.toml").readText()).getTable("versions")
1616
}

0 commit comments

Comments
 (0)