Using Envelope.adsr seems to crash server

[dayunbao]

I want to use Envelope.adsr in SynthDef like this:

@synthdef()
def multi_osc(
    frequency=440.0, 
    pulse_width=0.5, 
    amplitude=0.5, 
    add=0.0, 
    pan=0.0, 
    out_bus=0, 
    osc_type=0.0, 
    attack=0.01, 
    decay=0.3,
    sustain=0.5,
    release=1,
    gate=1,
):
    oscillators  = [
        SinOsc.ar(frequency=frequency),
        LFTri.ar(frequency=frequency),
        LFSaw.ar(frequency=frequency),
        LFPulse.ar(frequency=frequency, width=pulse_width),
        WhiteNoise.ar(),
    ]
    signal = Select.ar(sources=oscillators, selector=osc_type)
    signal *= amplitude
    signal += add
    signal = Pan2.ar(source=signal, position=pan)
    adsr = Envelope.adsr(attack_time=attack, decay_time=decay, sustain=sustain, release_time=release)
    env = EnvGen.kr(envelope=adsr, gate=gate, done_action=2)
    signal *= env
    Out.ar(bus=out_bus, source=signal)

but when I do, it crashes the server. This is what the logger spits out:

INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: Jack: Process: graph not finished!
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: Jack: Process: waiting to switch delta = 22002
INFO:supriya.osc.protocols:[127.0.0.1:57110/0x71a42ce10650] healthcheck: checking ...
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: JackEngine::XRun: client = SuperCollider was not finished, state = Running
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: JackAudioDriver::ProcessGraphAsyncMaster: Process error
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: Jack: JackRequest::Notification
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: Jack: JackEngine::ClientNotify: no callback for notification = 3
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: Jack: JackEngine::ClientNotify: no callback for notification = 3
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: Jack: JackExternalClient::ClientNotify ref = 2 client = SuperCollider name = SuperCollider notify = 3
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: Jack: Process: graph not finished!
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: Jack: Process: switch to next state delta = 42862
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: Jack: Process: graph not finished!
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: Jack: Process: waiting to switch delta = 20904
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: JackEngine::XRun: client = SuperCollider was not finished, state = Triggered
INFO:components.multi_oscillator:
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: JackAudioDriver::ProcessGraphAsyncMaster: Process error
INFO:components.multi_oscillator:Received Note Off for note 11
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] received: Jack: JackRequest::Notification
INFO:components.multi_oscillator:
Exception in thread Thread-8 (consume_midi_messages):
Traceback (most recent call last):
INFO:supriya.contexts.realtime:[127.0.0.1:57110/0x71a42ce21910] disconnecting ...
  File "/home/hideaki/.pyenv/versions/3.11.8/lib/python3.11/threading.py", line 1045, in _bootstrap_inner
INFO:supriya.osc.protocols:[127.0.0.1:57110/0x71a42ce10650] disconnecting ...
INFO:supriya.osc.protocols:[127.0.0.1:57110/0x71a42ce10650] ... disconnected!
    self.run()
  File "/home/hideaki/.pyenv/versions/3.11.8/lib/python3.11/threading.py", line 982, in run
INFO:supriya.contexts.realtime:[127.0.0.1:57110/0x71a42ce21910] disconnected!
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] quitting ...
INFO:supriya.scsynth:[127.0.0.1:57110/0x71a42d1279d0] ... already quit!
    self._target(*self._args, **self._kwargs)
  File "/home/hideaki/Code/chimera/app/modules/module.py", line 55, in consume_midi_messages
INFO:supriya.contexts.realtime:[127.0.0.1:57110/0x71a42ce21910] quit!

So I've been using this instead:

env=Linen.kr(gate=gate,attack_time=attack, sustain_level=sustain, release_time=release, done_action=2)

Am I doing something wrong, or is this a bug?

[josephine-wolf-oberholtzer]

I don't see the full traceback, just the beginning, interleaved with your log messages. Turn off the logging, and get the entire traceback. The first line of a traceback is always an unindented Traceback (most recent call last):, and the last line of a traceback is also unindented and starts with the exception type followed by a colon, e.g. ZeroDivisionError: division by zero. I cannot help you without the full information.

[josephine-wolf-oberholtzer]

Thanks for breaking it down. Inside a @synthdef, decay is actually a SynthDef parameter, not a float. Now, I think this should work, so we will need to verify if SuperCollider's EnvGen permits modulation on its arguments, or only permits scalar values.

[josephine-wolf-oberholtzer]

See https://doc.sccode.org/Classes/EnvGen.html

An Env instance, or an Array of Controls. (See Control and the example below for how to use this.)

The envelope is polled when the EnvGen is triggered, and at the start of a new envelope segment. The Env inputs can be other UGens.

Sounds like the args to Envelope should support modulation. Will need to write a test comparing how sclang compiles a modulable envelope vs how supriya does it.

See the More examples at the bottom of https://doc.sccode.org/Classes/EnvGen.html. I think the sclang ones are super unwieldy, but you can see how they're doing it.

[dayunbao]

I can try playing around with something like the examples where they specify an envelope for each new synth:

(
SynthDef(\help_Env_newClear, { |out = 0|
    var env, envctl;
    // make an empty 4 segment envelope
    env = Env.newClear(4);
    // create a control argument array
    envctl = \env.kr(env.asArray);
    Out.ar(out,
        SinOsc.ar(EnvGen.kr(envctl, \gate.tr), 0, 0.3) // the gate control is a trigger
    );
}).add;
)

Synth(\help_Env_newClear, [\gate, 1, \env, Env([700,900,900,800], [1,1,1], \exp)]); // 3 segments

// reset then play again:
Synth(\help_Env_newClear, [\gate, 1, \env, Env({ rrand(60, 70).midicps } ! 4, [1,1,1], \exp)]);

By the way, I got the TR-808 modeled drums from here: https://www.patreon.com/posts/sc-808-free-40121526. Those drums are connected to MIDI, including receiving Continuous Control messages. I'll have to look at how the creator, Yoshinosuke Horiuchi, did it. The drums sound quite good, actually.

[dayunbao]

See https://doc.sccode.org/Classes/EnvGen.html

An Env instance, or an Array of Controls. (See Control and the example below for how to use this.)

The envelope is polled when the EnvGen is triggered, and at the start of a new envelope segment. The Env inputs can be other UGens.

Sounds like the args to Envelope should support modulation. Will need to write a test comparing how sclang compiles a modulable envelope vs how supriya does it.

See the More examples at the bottom of https://doc.sccode.org/Classes/EnvGen.html. I think the sclang ones are super unwieldy, but you can see how they're doing it.

After a bit of playing around, I've found something that works:

@synthdef()
def multi_osc(
    frequency=440.0, 
    adsr=(0.01, 0.3, 0.5, 1.0),
    pulse_width=0.5, 
    amplitude=0.5, 
    add=0.0, 
    pan=0.0, 
    out_bus=0, 
    osc_type=0.0, 
    gate=1,
):
    oscillators  = [
        SinOsc.ar(frequency=frequency),
        LFTri.ar(frequency=frequency),
        LFSaw.ar(frequency=frequency),
        LFPulse.ar(frequency=frequency, width=pulse_width),
        WhiteNoise.ar(),
    ]
    signal = Select.ar(sources=oscillators, selector=osc_type)
    signal *= amplitude
    signal += add
    signal = Pan2.ar(source=signal, position=pan)
    
    attack = adsr[0]
    decay = adsr[1]
    sustain = adsr[2]
    release = adsr[3]
    adsr_envelope = Envelope.adsr(attack_time=attack, decay_time=decay, sustain=sustain, release_time=release)
    env = EnvGen.kr(envelope=adsr_envelope, gate=gate, done_action=2)
    
    signal *= env
    Out.ar(bus=out_bus, source=signal)

I create the adsr tuple from attributes in my DualOscillator class, and those attributes are set by slide potentiometers on a breadboard. I might be able to assign the values like this Envelope.adsr(attack_time=adsr[0]...), but I'm stopping for the day. My brain is getting fried.