Merge pull request #641 from superform-xyz/tamara-sup-8925-fail-sooner-in-completecrosschainrebalance

0xTimepunk · web-flow · commit 747a726e1ef8 · 2024-10-18T20:02:43.000+01:00
fix: Add revert for invalid rebalance selector
diff --git a/src/router-plus/SuperformRouterPlusAsync.sol b/src/router-plus/SuperformRouterPlusAsync.sol
@@ -399,6 +399,8 @@ contract SuperformRouterPlusAsync is ISuperformRouterPlusAsync, BaseSuperformRou
                 IBaseRouter.multiDstMultiVaultDeposit,
                 (MultiDstMultiVaultStateReq(data.rebalanceToAmbIds, data.rebalanceToDstChainIds, multiSuperformData))
             );
+        } else {
+            revert INVALID_REBALANCE_SELECTOR();
         }
 
         _deposit(

Original file line number	Diff line number	Diff line change
`@@ -399,6 +399,8 @@ contract SuperformRouterPlusAsync is ISuperformRouterPlusAsync, BaseSuperformRou`
`399`	`399`	`IBaseRouter.multiDstMultiVaultDeposit,`
`400`	`400`	`(MultiDstMultiVaultStateReq(data.rebalanceToAmbIds, data.rebalanceToDstChainIds, multiSuperformData))`
`401`	`401`	`);`
	`402`	`+ } else {`
	`403`	`+ revert INVALID_REBALANCE_SELECTOR();`
`402`	`404`	`}`
`403`	`405`
`404`	`406`	`_deposit(`