Merge pull request #648 from superform-xyz/fix-audit-recommendations

TamaraRingas · web-flow · commit 382eedb980e1 · 2024-10-28T15:29:25.000+02:00
fix: audit recommendation
diff --git a/src/router-plus/SuperformRouterPlus.sol b/src/router-plus/SuperformRouterPlus.sol
@@ -524,8 +524,7 @@ contract SuperformRouterPlus is ISuperformRouterPlus, BaseSuperformRouterPlus {
 
         /// @dev validate the slippage
         if (
-            (balanceDifference != assets)
-                || (ENTIRE_SLIPPAGE * assets < ((expectedOutputAmount_ * (ENTIRE_SLIPPAGE - maxSlippage_))))
+            (ENTIRE_SLIPPAGE * assets < ((expectedOutputAmount_ * (ENTIRE_SLIPPAGE - maxSlippage_))))
         ) {
             revert ASSETS_RECEIVED_OUT_OF_SLIPPAGE();
         }

Original file line number	Diff line number	Diff line change
`@@ -524,8 +524,7 @@ contract SuperformRouterPlus is ISuperformRouterPlus, BaseSuperformRouterPlus {`
`524`	`524`
`525`	`525`	`/// @dev validate the slippage`
`526`	`526`	`if (`
`527`		`- (balanceDifference != assets)`
`528`		`- \|\| (ENTIRE_SLIPPAGE * assets < ((expectedOutputAmount_ * (ENTIRE_SLIPPAGE - maxSlippage_))))`
	`527`	`+ (ENTIRE_SLIPPAGE * assets < ((expectedOutputAmount_ * (ENTIRE_SLIPPAGE - maxSlippage_))))`
`529`	`528`	`) {`
`530`	`529`	`revert ASSETS_RECEIVED_OUT_OF_SLIPPAGE();`
`531`	`530`	`}`