From e2b752e8c4a184d818748af9fd1248f648978e9b Mon Sep 17 00:00:00 2001 From: Nyannyacha Date: Mon, 13 May 2024 23:40:00 +0000 Subject: [PATCH] fix: make EmitterFactory respect `allow_remote_modules` option when determining `no npm` mode --- crates/sb_graph/emitter.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/crates/sb_graph/emitter.rs b/crates/sb_graph/emitter.rs index 6a34975b0..a19421c9f 100644 --- a/crates/sb_graph/emitter.rs +++ b/crates/sb_graph/emitter.rs @@ -327,6 +327,7 @@ impl EmitterFactory { pub fn cli_graph_resolver_options(&self) -> CliGraphResolverOptions { CliGraphResolverOptions { maybe_import_map: self.maybe_import_map.clone(), + no_npm: !self.file_fetcher_allow_remote, ..Default::default() } } @@ -339,7 +340,11 @@ impl EmitterFactory { self.package_json_deps_provider().clone(), self.package_json_deps_installer().await.clone(), self.cli_graph_resolver_options(), - Some(self.npm_resolver().await.clone()), + if self.file_fetcher_allow_remote { + Some(self.npm_resolver().await.clone()) + } else { + None + }, ))) }) .await