Fixing issues on Appveyor tests

* Need to close files before re using and closing
tempfile.NamedTemporaryFile also deletes it by default
* Removed some unnecessary UI message checks
* Excluded branches with 'win', 'windows' or 'Appveyor' from Travis
builds

Author: suoto

.travis.yml

@@ -21,6 +21,10 @@ stages:
   - test
   - deploy
 
+branches:
+  except:
+  - /.*?\b((?i:windows)|(?i:win)|(?i:appveyor))\b.*/
+
 jobs:
   include:
     - name: Python 2.7

hdl_checker/tests/test_base_server.py

@@ -122,19 +122,6 @@ def _makeConfigFromDict(dict_):
 
     it.assertSameFile = assertSameFile(it)
 
-    def _assertMsgQueueIsEmpty(project):
-        msg = []
-        while not project._msg_queue.empty():
-            msg += [str(project._msg_queue.get())]
-
-        if msg:
-            msg.insert(
-                0, "Message queue should be empty but has %d messages" % len(msg)
-            )
-            it.fail("\n".join(msg))
-
-    it.assertMsgQueueIsEmpty = _assertMsgQueueIsEmpty
-
     @it.should("warn when setup is taking too long")
     @patch("hdl_checker.base_server._HOW_LONG_IS_TOO_LONG", 0.1)
     @patch.object(
@@ -578,8 +565,6 @@ def test():
                 diagnostics,
             )
 
-            it.assertMsgQueueIsEmpty(it.project)
-
             it.assertTrue(it.project.database.paths)
 
         @it.should("get messages for relative path")  # type: ignore
@@ -591,8 +576,6 @@ def test():
 
             it.assertFalse(p.isabs(filename))
 
-            it.assertMsgQueueIsEmpty(it.project)
-
             diagnostics = it.project.getMessagesByPath(Path(filename))
 
             it.assertIn(
@@ -606,8 +589,6 @@ def test():
                 diagnostics,
             )
 
-            it.assertMsgQueueIsEmpty(it.project)
-
         @it.should("get messages with text")  # type: ignore
         def test():
             it.assertTrue(it.project.database.paths)
@@ -625,8 +606,6 @@ def test():
             for lnum, line in enumerate(content.split("\n")):
                 _logger.debug("%2d| %s", (lnum + 1), line)
 
-            it.assertMsgQueueIsEmpty(it.project)
-
             diagnostics = set(it.project.getMessagesWithText(filename, content))
 
             logIterable("Diagnostics", diagnostics, _logger.info)
@@ -651,7 +630,6 @@ def test():
             ]
 
             it.assertCountEqual(diagnostics, expected)
-            it.assertMsgQueueIsEmpty(it.project)
 
         @it.should(  # type: ignore
             "get messages with text for file outside the project file"
@@ -664,8 +642,6 @@ def test():
                 ["library work;", "use work.all;", "entity some_entity is end;"]
             )
 
-            it.assertMsgQueueIsEmpty(it.project)
-
             diagnostics = it.project.getMessagesWithText(filename, content)
 
             _logger.debug("Records received:")
@@ -688,14 +664,10 @@ def test():
 
                 raise
 
-            it.assertMsgQueueIsEmpty(it.project)
-
         @it.should("get updated messages")  # type: ignore
         def test():
             filename = Path(p.join(TEST_PROJECT, "another_library", "foo.vhd"))
 
-            it.assertMsgQueueIsEmpty(it.project)
-
             code = open(str(filename), "r").read().split("\n")
 
             code[28] = "-- " + code[28]
@@ -719,14 +691,10 @@ def test():
                 code[28] = code[28][3:]
                 writeListToFile(str(filename), code)
 
-            it.assertMsgQueueIsEmpty(it.project)
-
         @it.should("get messages by path of a different source")  # type: ignore
         def test():
             filename = Path(p.join(TEST_PROJECT, "basic_library", "clock_divider.vhd"))
 
-            it.assertMsgQueueIsEmpty(it.project)
-
             it.assertCountEqual(
                 it.project.getMessagesByPath(filename),
                 [
@@ -740,17 +708,13 @@ def test():
                 ],
             )
 
-            it.assertMsgQueueIsEmpty(it.project)
-
         @it.should(  # type: ignore
             "get messages from a source outside the project file"
         )
         def test():
             filename = Path(p.join(TEST_TEMP_PATH, "some_file.vhd"))
             writeListToFile(str(filename), ["library some_lib;"])
 
-            it.assertMsgQueueIsEmpty(it.project)
-
             diagnostics = it.project.getMessagesByPath(filename)
 
             _logger.info("Records found:")
@@ -766,8 +730,6 @@ def test():
                 "message here indicating an error",
             )
 
-            it.assertMsgQueueIsEmpty(it.project)
-
         def basicRebuildTest(test_filename, rebuilds):
             calls = []
             ret_list = list(reversed(rebuilds))

hdl_checker/tests/test_database.py

@@ -175,8 +175,9 @@ def test_AcceptsEmptySourcesList(self, meth):
         # type: (...) -> Any
         # Make TEST_TEMP_PATH/some_path.vhd readable so it is returned by
         # findRtlSourcesByPath
-        with tempfile.NamedTemporaryFile(suffix=".vhd") as path:
+        with tempfile.NamedTemporaryFile(suffix=".vhd", delete=False) as path:
             meth.return_value = [Path(path.name)]
+            path.close()
 
             self.database.configure(dict(), TEST_TEMP_PATH)
 
@@ -196,8 +197,9 @@ def test_AcceptsEmptyDict(self, meth):
         # type: (...) -> Any
         # Make TEST_TEMP_PATH/some_path.vhd readable so it is returned by
         # findRtlSourcesByPath
-        with tempfile.NamedTemporaryFile(suffix=".vhd") as path:
+        with tempfile.NamedTemporaryFile(suffix=".vhd", delete=False) as path:
             meth.return_value = [Path(path.name)]
+            path.close()
 
             self.database.configure({}, TEST_TEMP_PATH)