Removing dependency on 'sort' parm for git ls-remote

Author: suoto

hdl_checker/tests/test_misc.py

@@ -115,7 +115,6 @@ def test_GetCorrectVersion(self, popen):
 
         self.assertEqual(_getLatestReleaseVersion(), "0.6.3")
 
-
     @patch("hdl_checker.utils.subp.Popen")
     def test_RejectsInvalidFormats(self, popen):
         process_mock = Mock()
@@ -134,6 +133,9 @@ def test_RejectsInvalidFormats(self, popen):
     def test_HandlesNoConnection(self, *_):
         self.assertIsNone(_getLatestReleaseVersion())
 
+    def test_UnmockedCallWorks(self):
+        self.assertIsNotNone(_getLatestReleaseVersion())
+
 
 @patch("hdl_checker.utils._getLatestReleaseVersion", return_value="1.0.0")
 @patch("hdl_checker.__version__", "0.9.0")

hdl_checker/utils.py

@@ -406,7 +406,7 @@ def _getLatestReleaseVersion():
     the URL fails, return None
     """
     proc = subp.Popen(
-        ["git", "ls-remote", "--sort=v:refname", "--tags", REPO_URL],
+        ["git", "ls-remote", "--tags", REPO_URL],
         env={"GIT_TERMINAL_PROMPT": "0"},
         stdout=subp.PIPE,
         stderr=subp.PIPE,
@@ -426,7 +426,7 @@ def _getLatestReleaseVersion():
 
     tags = [x.decode() for x in stdout.splitlines()]
 
-    latest = tags[-1].split("/")[-1]
+    latest = sorted(tags[-1].split("/"))[-1]
 
     if not re.match(r"v\d+\.\d+\.\d+", latest):
         _logger.info("Don't know how to handle version format on %s", latest)