Skip to content
This repository was archived by the owner on Mar 19, 2025. It is now read-only.
This repository was archived by the owner on Mar 19, 2025. It is now read-only.

HttpStatusをハードコーディング→HttpStatusのenumを利用する #271

@sunakan

Description

@sunakan

背景

lintツール:detektのデフォに合わせていきたい(現状は200などの固定値を許している)

config/detekt/detekt-override.yml をなくせたら理想

  #
  # MagicNumber
  #
  # 概要
  # - マジックナンバーはOUT
  #
  MagicNumber:
    active: true
    excludes: ['**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/jsTest/**', '**/iosTest/**', '**/*.kts']
    ignoreNumbers: # (default: ['-1', '0', '1', 2])
      - '-1'
      - '0'
      - '1'
      - '2'
      - '200'
      - '201'
      - '400'
      - '401'
      - '403'
      - '404'
      - '422'
      - '500'

実際の対応例

Before

val expectedStatus = 200

After

val expectedStatus = HttpStatus.OK.value()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions