Skip to content

Commit 90d33cf

Browse files
committed
Improve docs pt.2
1 parent f905c53 commit 90d33cf

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

src/block/decoder.rs

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ use std::mem::MaybeUninit;
1616
use std::ptr;
1717
use std::ptr::NonNull;
1818

19-
/// The decoder will work on the buffer defined in a Config, it shall contain
19+
/// The decoder will work on the buffer defined in the builder, it shall contain
2020
/// raw trace data and remain valid for the lifetime of the decoder.
2121
///
2222
/// The decoder needs to be synchronized before it can be used.
@@ -28,9 +28,9 @@ pub struct BlockDecoder<'a> {
2828
}
2929

3030
impl PtEncoderDecoder for BlockDecoder<'_> {
31-
/// Allocate an Intel PT block decoder.
31+
/// Create an Intel PT block decoder.
3232
///
33-
/// The decoder will work on the buffer defined in @config,
33+
/// The decoder will work on the buffer defined in @builder,
3434
/// it shall contain raw trace data and remain valid for the lifetime of the decoder.
3535
/// The decoder needs to be synchronized before it can be used.
3636
fn new_from_builder(builder: &EncoderDecoderBuilder<Self>) -> Result<Self, PtError> {
@@ -51,8 +51,7 @@ impl PtEncoderDecoder for BlockDecoder<'_> {
5151
impl BlockDecoder<'_> {
5252
/// Return the current address space identifier.
5353
///
54-
/// On success, provides the current address space identifier in @asid.
55-
/// Returns Asid on success, a `PtError` otherwise.
54+
/// On success, provides the current address space identifier a `PtError` otherwise.
5655
pub fn asid(&self) -> Result<Asid, PtError> {
5756
let mut asid = MaybeUninit::<pt_asid>::uninit();
5857
ensure_ptok(unsafe {
@@ -76,7 +75,7 @@ impl BlockDecoder<'_> {
7675

7776
/// Get the next pending event.
7877
///
79-
/// On success, provides the next event, a `StatusFlag` instance and updates the decoder.
78+
/// On success, provides the next event, a `Status` instance and updates the decoder.
8079
/// Returns `BadQuery` if there is no event.
8180
pub fn event(&mut self) -> Result<(Event, Status), PtError> {
8281
let mut evt = MaybeUninit::<pt_event>::uninit();
@@ -135,16 +134,16 @@ impl BlockDecoder<'_> {
135134
/// Determine the next block of instructions.
136135
///
137136
/// On success, provides the next block of instructions in execution order.
138-
/// Also Returns a `StatusFlag` instance on success.
137+
/// Also Returns a `Status` instance on success.
139138
/// Returns Eos to indicate the end of the trace stream.
140-
/// Subsequent calls to next will continue to return Eos until trace is required to determine the next instruction.
139+
/// Subsequent calls will continue to return Eos until trace is required to determine the next instruction.
141140
/// Returns `BadContext` if the decoder encountered an unexpected packet.
142141
/// Returns `BadOpc` if the decoder encountered unknown packets.
143142
/// Returns `BadPacket` if the decoder encountered unknown packet payloads.
144143
/// Returns `BadQuery` if the decoder got out of sync.
145-
/// Returns Eos if decoding reached the end of the Intel PT buffer.
146-
/// Returns Nomap if the memory at the instruction address can't be read.
147-
/// Returns Nosync if the decoder is out of sync.
144+
/// Returns `Eos` if decoding reached the end of the Intel PT buffer.
145+
/// Returns `Nomap` if the memory at the instruction address can't be read.
146+
/// Returns `Nosync` if the decoder is out of sync.
148147
pub fn decode_next(&mut self) -> Result<(Block, Status), PtError> {
149148
let mut blk = MaybeUninit::<pt_block>::uninit();
150149
let status = extract_status_or_pterr(unsafe {

src/enc_dec_builder/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ impl<T> EncoderDecoderBuilder<T>
8181
where
8282
T: PtEncoderDecoder,
8383
{
84-
/// Initializes an EncoderDecoderBuilder instance
84+
/// Create an EncoderDecoderBuilder
8585
pub const fn new() -> Self {
8686
let mut config: pt_config = unsafe { mem::zeroed() };
8787
config.size = size_of::<pt_config>();

0 commit comments

Comments
 (0)