Merge pull request #1061 from sul-dlss/do-not-compact-bool

Do not compact away false values

Author: dnoneill

app/services/versioned_files_service/metadata.rb

@@ -26,6 +26,8 @@ def self.deep_compact_blank(node)
         when Array
           compacted_array = value.map { |v| deep_compact_blank(v) }.compact_blank
           output[key] = compacted_array unless compacted_array.empty?
+        when TrueClass, FalseClass
+          output[key] = value
         else
           output[key] = value if value.present?
         end

spec/services/versioned_files_service/metadata_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe VersionedFilesService::Metadata do
+  describe '.deep_compact_blank' do
+    subject { described_class.deep_compact_blank(input) }
+
+    context 'with false values' do
+      let(:input) do
+        {
+          administrative: {
+            publish: true,
+            sdrPreserve: false,
+            shelve: true
+          }
+        }
+      end
+
+      it { is_expected.to eq(input) }
+    end
+  end
+end