Skip to content

Helm charts generate invalid YAML for collaboration API / WS #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bmcgavin opened this issue Apr 18, 2025 · 0 comments · May be fixed by #891
Open

Helm charts generate invalid YAML for collaboration API / WS #890

bmcgavin opened this issue Apr 18, 2025 · 0 comments · May be fixed by #891

Comments

@bmcgavin
Copy link

Bug Report

Problematic behavior
Helm charts provide invalid YAML in kubernetes >=1.19 due to duplication of service blocks in ingress_collaboration_api and ingress_collaboration_ws templates.

Expected behavior/code
Helm can install the chart

Steps to Reproduce

  1. attempt to install via helm on kubernetes >=1.19

Environment

  • Kubernetes version: >=1.19

Possible Solution
This pattern is used throughout the helm templates:

             backend:
              {{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
              service:
                name: {{ include "impress.backend.fullname" . }}
                port:
                  number: {{ .Values.backend.service.port }}
              {{- else }}
              serviceName: {{ include "impress.backend.fullname" . }}
              servicePort: {{ .Values.backend.service.port }}
            {{- end }}

Only in two services referenced there is an extra service block outside of the if:

            backend:
              service:
                name: {{ include "impress.yProvider.fullname" . }}
                port:
                  number: {{ .Values.yProvider.service.port }}
              {{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
              service:
                name: {{ include "impress.yProvider.fullname" . }}
                port:
                  number: {{ .Values.yProvider.service.port }}
              {{- else }}
              serviceName: {{ include "impress.yProvider.fullname" . }}
              servicePort: {{ .Values.yProvider.service.port }}
            {{- end }}

I'll make a PR removing this extra service block.

Additional context/Screenshots
bmcgavin added a commit to bmcgavin/docs that referenced this issue Apr 18, 2025
@bmcgavin
🐛(helm) charts generate invalid YAML for collaboration API / WS
467b38f 
Closes suitenumerique#890

Remove the service blocks outside the conditionals in the collaboration
API and WS templates.
@bmcgavin bmcgavin linked a pull request Apr 18, 2025 that will close this issue
Open
bmcgavin added a commit to bmcgavin/docs that referenced this issue Apr 18, 2025
@bmcgavin
🐛(helm) charts generate invalid YAML for collaboration API / WS
5ae9993 
Closes suitenumerique#890

Remove the service blocks outside the conditionals in the collaboration
API and WS templates.

Signed-off-by: Richard Jones <rich@linuxplicable.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Docs - La Suite
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛(helm) charts generate invalid YAML for collaboration API / WS bmcgavin/docs
1 participant
@bmcgavin